980037 - Store scaled images in volatile buffers

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Michael Wu [:mwu]]

Attachment: Store scaled images in volatile buffers

Comment 1

[Steven Yang [:styang]]

Hi Michael, do you have any idea how much RAM/perf will be improved by this? thanks.

Comment 2

[Jason Smith [:jsmith]]

Why was this marked 1.3+? Was that by accident or intentional?

Comment 3

[Seth Fowler [:seth] [:s2h]]

Comment on attachment 8386316 [details] [diff] [review]
Store scaled images in volatile buffers

Review of attachment 8386316 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good.

Comment 4

[[:fabrice] Fabrice Desré]

My bad, wrong flag.

Comment 5

[Michael Wu [:mwu]]

(In reply to Steven Yang [:styang] from comment #1)
> Hi Michael, do you have any idea how much RAM/perf will be improved by this?
> thanks.

This one primarily affects websites where we scale larger images down to fit the screen. It allows the scaled down version to also be thrown away under memory pressure. It's basically an improvement on bug 962670. I don't expect it to help as much as bug 962670, but it should have similar effects when we do generate scaled down images.

Comment 6

[Michael Wu [:mwu]]

https://hg.mozilla.org/integration/b2g-inbound/rev/e09f4b94cf29

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e09f4b94cf29

Comment 8

[Michael Wu [:mwu]]

Attachment: Store scaled images in volatile buffers for v1.3t

Here's a v1.3t version of the patch.

Comment 9

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3t/rev/eb027b989adf