Closed
Bug 980094
Opened 12 years ago
Closed 12 years ago
[Camera] Moving setter and enabler methods to the view base class
Categories
(Firefox OS Graveyard :: Gaia::Camera, defect)
Tracking
(b2g-v1.4 fixed, b2g-v2.0 fixed)
RESOLVED
FIXED
1.4 S5 (11apr)
People
(Reporter: dmarcos, Assigned: dmarcos)
References
Details
Attachments
(1 file)
These methods are helpful for the views in general and not specific to the controls view.
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → dmarcos
|
|
Assignee | |
Updated•12 years ago
|
Summary: [Camera] Moving methods from controls view to the view base class → [Camera] Moving setter and enabler methods from controls view to the view base class
|
|
Assignee | |
Updated•12 years ago
|
Summary: [Camera] Moving setter and enabler methods from controls view to the view base class → [Camera] Moving setter and enabler methods the view base class
|
|
Assignee | |
Comment 1•12 years ago
|
||
Those methods are currently implemented in two places HudView and ControlsView. There's code duplication so we need to factor out this functions to the base class.
|
|
Assignee | |
Comment 2•12 years ago
|
||
Attachment #8386467 -
Flags: review?(dflanagan)
|
|
Assignee | |
Updated•12 years ago
|
Summary: [Camera] Moving setter and enabler methods the view base class → [Camera] Moving setter and enabler methods to the view base class
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8386467 [details] [review]
pull-request (camera-new-features)
r+. Thanks for breaking this out into a separate pull request. It makes for very easy review!
Attachment #8386467 -
Flags: review?(dflanagan) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Merged in camera-new-features:
https://github.com/mozilla-b2g/gaia/commit/5ba8ee4980c649fcdb536bda962502b048addd89
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Comment 5•12 years ago
|
||
Bulk edit for camera bugs.
If earlier comments do not show how this bug landed to master, it probably landed as part of https://github.com/mozilla-b2g/gaia/pull/17599 which merged the camera-new-features branch into master.
This bug was uplifted from master to v1.4 as part of https://github.com/mozilla-b2g/gaia/commit/a8190d08e61316a86bba572ba8d894d081a20530
You need to log in
before you can comment on or make changes to this bug.
Description
•