980180 - remove principals as an argument to compilation

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Everything in the same compartment has the same principals: compartment->principals.  Any compiled script is in cx->compartment.  Thus, having principals as an argument is strictly redundant.  We've had assertions on many paths that options.principals() == cx->compartment()->principals for a long time so it's time to remove all this.

28 files changed, 59 insertions(+), 285 deletions(-)

Comment 1

[Luke Wagner [:luke]]

Attachment: rm-principal-arg1

This patch removes the field from CompileOptions.  It also adds some asserts that 'principals == cx->compartment()->principals' on the few JSAPI paths that don't already have it so I can try-server to check: https://tbpl.mozilla.org/?tree=Try&rev=7828ece7e4fc

Comment 2

[Luke Wagner [:luke]]

Attachment: rm-principal-arg2

This patch removes the Evaluate* JSAPIs that take an explicit JSPrincipal.

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 8386553 [details] [diff] [review]
rm-principal-arg1

Review of attachment 8386553 [details] [diff] [review]:
-----------------------------------------------------------------

Righteous! r=me

Comment 4

[Terrence Cole [:terrence]]

Comment on attachment 8386554 [details] [diff] [review]
rm-principal-arg2

Review of attachment 8386554 [details] [diff] [review]:
-----------------------------------------------------------------

Epic! r=me

Comment 5

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7fd4f489f0ab
https://hg.mozilla.org/integration/mozilla-inbound/rev/3aa4c0b57f21

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3aa4c0b57f21
https://hg.mozilla.org/mozilla-central/rev/7fd4f489f0ab