980251 - Provide a simple way to run the test runner in B2G Desktop

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TestAgent, defect)

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: github PR

Make bin/gaia-test takes an option to run in B2G Desktop instead of Firefox

 bin/gaia-test | 161 +++++++++++++++++++++++++++++++++++++++++-----------------
 1 file changed, 115 insertions(+), 46 deletions(-)

I used "-d" instead of "-b" because I thought that "-b" could be used in a follow-up patch to specify the binary to use (instead of using the second argument). We could also use "-g" to specify the gaia dir, while still retaining the current way.

Comment 2

[Julien Wajsberg [:julienw]]

Comment on attachment 8386671 [details] [review]
github PR

Rik, I know you use this script too, so I'd value your feedback on this.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8386671 [details] [review]
github PR

Looks good except for a typo in the getops logic.  I assume you switched from -b to -d at the last minute.

After fixing that I'm able to select b2g-desktop, have it download, and run.  I don't have a convenient place to fully run the tests at the moment (headless linux VM), but it seems to run correctly.

It might be nice to have some safety checks using --version on the binary to see if someone says "use b2g-desktop" but then specifies a firefox binary on the command line.  I don't think thats worth holding back for, though.

Comment 4

[Julien Wajsberg [:julienw]]

(In reply to Ben Kelly [:bkelly] from comment #3)
> Comment on attachment 8386671 [details] [review]
> github PR
> 
> Looks good except for a typo in the getops logic.  I assume you switched
> from -b to -d at the last minute.

oops :) yep !


> 
> After fixing that I'm able to select b2g-desktop, have it download, and run.
> I don't have a convenient place to fully run the tests at the moment
> (headless linux VM), but it seems to run correctly.
> 
> It might be nice to have some safety checks using --version on the binary to
> see if someone says "use b2g-desktop" but then specifies a firefox binary on
> the command line.  I don't think thats worth holding back for, though.

Yep, I didn't exactly know which one we wanted, so I said, well, most of users will download it, and users that specify a specific binary know what they do.

Thanks !

Comment 5

[Julien Wajsberg [:julienw]]

Pushed the fixed version to the PR. I'll give a chance to Anthony to answer and otherwise I'll merge tonight.

Comment 6

[Julien Wajsberg [:julienw]]

master: 04eb7996543f114133d1367f834a4d88b68c60ac

Comment 7

[Julien Wajsberg [:julienw]]

Anthony, if you have any concern, please file a bug :)

Comment 8

[Anthony Ricaud (:rik)]

Comment on attachment 8386671 [details] [review]
github PR

Nope, it works well locally so good for me.

It should probably be mentioned on https://developer.mozilla.org/en-US/Firefox_OS/Platform/Automated_testing/Gaia_unit_tests ?

Comment 9

[Julien Wajsberg [:julienw]]

yep

Comment 10

[Julien Wajsberg [:julienw]]

Updated a lot of https://developer.mozilla.org/en-US/Firefox_OS/Platform/Automated_testing/Gaia_unit_tests