Closed Bug 980295 Opened 8 years ago Closed 8 years ago

Fix documentation for hgrc [extension] paths for Windows

Categories

(Developer Services :: Mercurial: hg.mozilla.org, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

Details

Attachments

(1 file)

On Unix based filesystems, any of the following will work in an hgrc:

[extensions]
bar = /foo/bar
baz = /foo/baz/

However on Windows, the second case in this example will fail, due to the trailing slash:

[extensions]
bar = c:\foo\bar
baz = c:\foo\baz\

I've reported & fixed this bug upstream (http://bz.selenic.com/show_bug.cgi?id=4187), however we should fix documentation that lists the trailing slash case, to avoid confusing new contributors using Mercurial 1.9.1 or earlier.

(I should add that it's for this reason that for years my hgrc contains direct references to the .py files in the paths rather than the directories, due to me trying things randomly when the various hg extension README instructions didn't work, which caused things to break post some of the deps of bug 968958).
Fixes these three:

(In reply to Ed Morley [:edmorley UTC+0] from comment #1)
> Needs fixing:
...
> https://hg.mozilla.org/hgcustom/version-control-tools/file/eaa64fd26c39/
> hgext/bzexport/README
> https://hg.mozilla.org/hgcustom/version-control-tools/file/eaa64fd26c39/
> hgext/qbackout/README
> https://hg.mozilla.org/hgcustom/version-control-tools/file/eaa64fd26c39/
> hgext/qimportbz/README
This just leaves:

(In reply to Ed Morley [:edmorley UTC+0] from comment #1)
> Needs fixing:
> https://bitbucket.org/sfink/trychooser/src/
> beed16e594800e2e0af4171d876d6c93390a2099/README.md?at=default

Steve, would you mind removing the trailing slash from the example hgrc [extensions] entry at the location linked here?

Commit message I used for comment 3, for inspiration:
"Bug 980295 - Remove trailing slash from README paths, for compat with hg < v3.0 on Windows"

Thanks :-)
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Product: Release Engineering → Developer Services
You need to log in before you can comment on or make changes to this bug.