980354 - B2G SMS & MMS: can't populate MobileMessageDB in marionette test cases

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Vicamo Yang [:vicamo][:vyang]]

+++ This bug was initially created as a clone of Bug #974820 +++

E/GeckoConsole(   45): [JavaScript Error: "Permission denied to access object" {file: "resource://gre/modules/MobileMessageDB.jsm" line: 1812}]

This is best illustrated in bug 930839 comment 7 by Kyle Huey.

Comment 1

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 1/2: add mmdb_head.js and run mmdb test cases in chrome context

By running mmdb related test cases with chrome context, the problems I had in bug 943233 and bug 930839 comment 7 are gone.  We then have to separate "head.js" and "mmdb_head.js" because there is no SpecialPowers within chrome context.

Comment 2

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 2/2: test cases

Add some more test cases in "test_mmdb_full_storage.js" as examples.

Comment 3

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8387016 [details] [diff] [review]
part 2/2: test cases

Only touched Mobile Message marionette test cases: https://tbpl.mozilla.org/?tree=Try&rev=84019ed69843

Comment 4

[Vicamo Yang [:vicamo][:vyang]]

Comment on attachment 8387016 [details] [diff] [review]
part 2/2: test cases

Ask for HsinYi's review because we're both in work week now.

Comment 6

[Gene Lian (I already quit Mozilla)]

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #4)
> Comment on attachment 8387016 [details] [diff] [review]
> part 2/2: test cases
> 
> Ask for HsinYi's review because we're both in work week now.

I found my review is reassigned when I'm available to clean up my review queue today. Thank you guys! Please let me know if you still need my support. Thanks!

Comment 7

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8387014 [details] [diff] [review]
part 1/2: add mmdb_head.js and run mmdb test cases in chrome context

Review of attachment 8387014 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/tests/marionette/test_mmdb_full_storage.js
@@ +31,3 @@
>      } else {
>        ok(false, "Unexpected result: " + aRv);
>        deferred.reject(aRv);

The change due to mmdb_head.js looks good, but I always encounter an error that leads to promise rejection (aRv = 0) with local marionette try. The test fails.

Comment 8

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8387014 [details] [diff] [review]
part 1/2: add mmdb_head.js and run mmdb test cases in chrome context

Review of attachment 8387014 [details] [diff] [review]:
-----------------------------------------------------------------

My bad... I was using an old build for previous tests. Everything works now.

Comment 9

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8387016 [details] [diff] [review]
part 2/2: test cases

Review of attachment 8387016 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/mobilemessage/tests/marionette/test_mmdb_full_storage.js
@@ +28,5 @@
> +  return saveSendingMessage(aMmdb, newSavableMessage())
> +    .then((aValue) => aValue[0],
> +          (aValue) => aValue[0])
> +    .then((aValue) => is(aValue, Cr.NS_ERROR_FILE_NO_DEVICE_SPACE, "Database error code"))
> +    .then(() => aMmdb);

Returning aMmdb is kinda annoying and not clear enough. Could we revise this as our offline discussion? Except this, everything looks good.

Comment 10

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 2/2: test cases : v2

1) Address previous review comment.  Add some comments at a few strange steps as well.
2) In |testMarkMessageRead|, the test should fail if |saveReceivedMessage| fails.

Comment 11

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 1/2: add mmdb_head.js and run mmdb test cases in chrome context

No change. r=hsinyi only.

Comment 12

[Vicamo Yang [:vicamo][:vyang]]

Attachment: part 2/2: test cases : v2

No change. r=hsinyi only.

Comment 13

[Vicamo Yang [:vicamo][:vyang]]

https://hg.mozilla.org/integration/b2g-inbound/rev/3103bfd98c39
https://hg.mozilla.org/integration/b2g-inbound/rev/93c1de515127

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3103bfd98c39
https://hg.mozilla.org/mozilla-central/rev/93c1de515127