Closed Bug 980369 Opened 7 years ago Closed 7 years ago
Update the illustration in the Customize Tip section
24.34 KB, application/zip
24.48 KB, application/zip
69.71 KB, patch
|Details | Diff | Splinter Review|
Customize illustration right-to-left
Comment on attachment 8387153 [details] [diff] [review] Patch v1: update customize tip illustrations and add an rtl mode version Yoink. Tried and tested. I dig.
Attachment #8387153 - Flags: review?(jaws) → review+
whoppa. pushed as: https://hg.mozilla.org/integration/fx-team/rev/6d86574dc562
Status: NEW → ASSIGNED
Whiteboard: [Australis:P3] → [Australis:P3][fixed-in-fx-team]
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P3][fixed-in-fx-team] → [Australis:P3]
Target Milestone: --- → Firefox 30
Comment on attachment 8387153 [details] [diff] [review] Patch v1: update customize tip illustrations and add an rtl mode version [Approval Request Comment] Bug caused by (feature/regressing bug #): follow-up of bug 870593 User impact if declined: 1) Users will see a less optimal version of the customize top illustration that is shown in the popup 2) RTL mode users will see an incorrect illustration Testing completed (on m-c, etc.): merged to m-c Risk to taking this patch (and alternatives if risky): minor String or IDL/UUID changes made by this patch: n/a
Attachment #8387153 - Flags: approval-mozilla-aurora?
Attachment #8387153 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Landed in one combined patch on aurora, together with bug 870593 and bug 980433: https://hg.mozilla.org/releases/mozilla-aurora/rev/92c7529e9169
backed-out (faulty commit msg): https://hg.mozilla.org/releases/mozilla-aurora/rev/2c495062cd5c relanded: https://hg.mozilla.org/releases/mozilla-aurora/rev/a97cdf6cdf40
You need to log in before you can comment on or make changes to this bug.