980369 - Update the illustration in the Customize Tip section

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: customize_illustration.zip

Assets attached.

Comment 1

[Michael Maslaney [:mmaslaney] ([e-mail])]

Attachment: customize_illustration_rtl.zip

Customize illustration right-to-left

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: update customize tip illustrations and add an rtl mode version

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8387153 [details] [diff] [review]
Patch v1: update customize tip illustrations and add an rtl mode version

Yoink.

Tried and tested. I dig.

Comment 4

[Mike de Boer [:mikedeboer]]

whoppa. pushed as: https://hg.mozilla.org/integration/fx-team/rev/6d86574dc562

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6d86574dc562

Comment 6

[Mike de Boer [:mikedeboer]]

Comment on attachment 8387153 [details] [diff] [review]
Patch v1: update customize tip illustrations and add an rtl mode version

[Approval Request Comment]
Bug caused by (feature/regressing bug #): follow-up of bug 870593
User impact if declined: 

1) Users will see a less optimal version of the customize top illustration that is shown in the popup
2) RTL mode users will see an incorrect illustration

Testing completed (on m-c, etc.): merged to m-c
Risk to taking this patch (and alternatives if risky): minor
String or IDL/UUID changes made by this patch: n/a

Comment 7

[Mike de Boer [:mikedeboer]]

Landed in one combined patch on aurora, together with bug 870593 and bug 980433:

https://hg.mozilla.org/releases/mozilla-aurora/rev/92c7529e9169

Comment 8

[Mike de Boer [:mikedeboer]]

backed-out (faulty commit msg): https://hg.mozilla.org/releases/mozilla-aurora/rev/2c495062cd5c
relanded: https://hg.mozilla.org/releases/mozilla-aurora/rev/a97cdf6cdf40