980401 - Make sure the XPCOM shutdown leak detector still detects things on TBPL

Status: RESOLVED WORKSFORME

(Testing :: Mochitest, defect)

Description

[Andrew McCreight [:mccr8]]

This is probably just me being paranoid, but I haven't noticed many leaks showing up on TBPL in the last month or so on trunk.  I looked up things tagged with intermittent-failure and mlk, and there are very few that have happened in the last month.

There's bug 969100 (last 2/6), bug 959079 (last 1/15), bug 957109 (last 1/7), but that's it in terms of things tagged as intermittent leaks happening this year.

One interesting data point is bug 891508, which used to hit a leak every time it failed, but starting 2013-10-21 it stopped leaking.  That could just be the mochitest memory improvements kicking in and stopping a cycle collector failure leak, or something.

Separately, RyanVM pointed out bug 974206 comment 1, which is a leak from 2014-02-24, which is recent, so things are probably okay.

Kyle pointed out that Jesse has been finding leaks, so if this is a failure, it is somewhere in the test harness TBPL stuff and not in Gecko itself.

I'll do a try push with some kind of intentional leak and see what happens.

Comment 1

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

The most recent leak I've seen Jesse find is bug 973522 which was on 2/17.

Comment 2

[Andrew McCreight [:mccr8]]

Kyle suggested I try the patch from bug 973522, so I did that:
  https://tbpl.mozilla.org/?tree=Try&rev=449f2652b617
One of the plain mochitests should leak.

Comment 3

[Andrew McCreight [:mccr8]]

Jesse, have you noticed any leaks on your fuzzers in the last few weeks?  Like, any.

Comment 4

[Andrew McCreight [:mccr8]]

For those following along at home, the try run I did resulted in a shutdown crash, so I should put together another try run that will leak.

Comment 5

[Andrew McCreight [:mccr8]]

I accidentally answered my own question by landing bug 975823 on inbound, which had a small leak that was detected by the XPCOM leak detector, on M5 and Crashtests.  So this does in fact work, we're just much better nowadays about not having intermittent leaks on TBPL.  Hooray!