980438 - Make progress bar thinner and darker

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

These refinements somehow got lost when bug 962103 relanded.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Make progress bar thinner and darker

Looks like I pulled in an older version of bug 962103 when relanding it. This was missing several changes:
* Thinner, darker progress bar
* Fixed the ToolbarProgressView in layout-large-v11
* Adds comment explaining clipChildren

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: Screenshot

Screenshot of changes.

Comment 3

[Lucas Rocha (:lucasr)]

Comment on attachment 8386946 [details] [diff] [review]
Make progress bar thinner and darker

Review of attachment 8386946 [details] [diff] [review]:
-----------------------------------------------------------------

K.

Comment 4

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/524608e2ef23

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/524608e2ef23

Comment 6

[Flaviu Cos]

Verified as fixed on build 30.0a1 (2014-03-10);
Device: Google Nexus 5 (Android 4.4.2)

Comment 7

[Aaron Train [:aaronmt]]

Is this supposed to hit 29? I forget.

Comment 8

[Ian Barlow (:ibarlow)]

Yes. It was part of the original 'minimum viable progress bar' design requirements which got lost somehow when bug 962103 landed. Definitely want this in 29.

Comment 9

[Lucas Rocha (:lucasr)]

Brian, please request uplift asap.

Comment 10

[Brian Nicholson (:bnicholson)]

There were too many regressions from progress bar to uplift this. And since the new progress bar changes have been backed out altogether, this bug is no longer relevant.