Closed Bug 980448 Opened 7 years ago Closed 7 years ago

modify-account section missing closing tag

Categories

(Firefox OS Graveyard :: Gaia::Calendar, defect)

x86
macOS
defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
1.4 S6 (25apr)

People

(Reporter: Eli, Assigned: mmedeiros)

Details

(Whiteboard: [p=1])

Attachments

(1 file)

The `modify-account` section at the end of the calendar index.html markup is missing its closing tag.

https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/index.html#L171
Assignee: nobody → mmedeiros
Whiteboard: [p=1]
Target Milestone: --- → 1.4 S6 (25apr)
Comment on attachment 8406879 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18333

lol
Attachment #8406879 - Flags: review?(gaye) → review+
This is actually the second instance of us creating invalid html in the calendar app. Perhaps we should have some html validation marionette plugin thing that can tap into the integration tests to verify that the html is always compliant...
Such errors wouldn't be reflected into the DOM which will have corrected things using the HTML5 parser rules.  You'd need to do the checking at a syntactic level, I think.  Since Calendar I think uses templates, that may be trickier than in something like e-mail where the r.js build step or runtime loader would be able to sanity-check HTML as it optimizes/loads.
landed into master https://github.com/mozilla-b2g/gaia/commit/227a66945612848ac382df70a617b4e107f6a75a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.