980448 - modify-account section missing closing tag

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[:Eli Perelman]

The `modify-account` section at the end of the calendar index.html markup is missing its closing tag.

https://github.com/mozilla-b2g/gaia/blob/master/apps/calendar/index.html#L171

Comment 1

[Miller Medeiros [:millermedeiros]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18333

Comment 2

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8406879 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18333

lol

Comment 3

[Gareth Aye [:gaye] (back from PTO)]

This is actually the second instance of us creating invalid html in the calendar app. Perhaps we should have some html validation marionette plugin thing that can tap into the integration tests to verify that the html is always compliant...

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Such errors wouldn't be reflected into the DOM which will have corrected things using the HTML5 parser rules.  You'd need to do the checking at a syntactic level, I think.  Since Calendar I think uses templates, that may be trickier than in something like e-mail where the r.js build step or runtime loader would be able to sanity-check HTML as it optimizes/loads.

Comment 5

[Miller Medeiros [:millermedeiros]]

landed into master https://github.com/mozilla-b2g/gaia/commit/227a66945612848ac382df70a617b4e107f6a75a