Closed
Bug 980496
Opened 10 years ago
Closed 10 years ago
Change the default profile folder used in bin/gaia-test and leverage PROFILE_FOLDER
Categories
(Firefox OS Graveyard :: Gaia::TestAgent, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: julienw, Assigned: julienw)
Details
Attachments
(1 file)
Currently we use "profile-debug" which is the default directory for "DEBUG=1 make". I think this is bad to use this one as we generate a "NO_LOCK_SCREEN=1 DESKTOP=0 DEBUG=1" profile and the user might not want this as his normal debug profile.
Assignee | ||
Comment 1•10 years ago
|
||
Hey Ben, tell me what you think of these changes :)
Assignee: nobody → felash
Attachment #8415421 -
Flags: review?(bkelly)
Comment 2•10 years ago
|
||
Comment on attachment 8415421 [details] [review] github PR To be honest, I haven't really looked at the gaia build system in a while. I suggest having Yuren or someone who's looked at the test infrastructure recently review it. Sorry!
Attachment #8415421 -
Flags: review?(bkelly) → review?(yurenju.mozilla)
Assignee | ||
Comment 3•10 years ago
|
||
Comment on attachment 8415421 [details] [review] github PR Ben, this is a patch for bin/gaia-test, which I think you know better than anyone else :) That's why I asked specifically _you_ a review ! The one-line change in Makefile is trivial but we can ask Yuren for this if you want.
Attachment #8415421 -
Flags: review?(yurenju.mozilla) → review?(bkelly)
Comment 4•10 years ago
|
||
Well, I can review to make sure its valid shell code, but I don't feel qualified to make decisions about how we manage profiles for gaia.
Comment 5•10 years ago
|
||
Comment on attachment 8415421 [details] [review] github PR r=me with the given comments on github. I trust that you've run this as I don't have a convenient setup to test locally at the moment.
Attachment #8415421 -
Flags: review?(bkelly) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8415421 [details] [review] github PR I fixed the changes that Ben outlined. I also added some more help in the "gaia-test -h" text, and changed "-p" to "-f" to force the profile regeneration. (because I'd eventually like to specify a profile directory using "-p" in addition to PROFILE_FOLDER). Yuren, Ben suggested that you should review this as well, and I think he's right :) so here is a review request for you! The main goal is to stop using profile-debug (which is the default profile directory when running DEBUG=1) because unit tests need a DEBUG=1 DESKTOP=0 profile.
Attachment #8415421 -
Flags: review?(yurenju.mozilla)
Comment 7•10 years ago
|
||
Comment on attachment 8415421 [details] [review] github PR that's a good idea for separating profile-debug and profile for gaia-test, thanks! and I have a question on github, please feel free to land it if it's not a problem.
Attachment #8415421 -
Flags: review?(yurenju.mozilla) → review+
Assignee | ||
Comment 8•10 years ago
|
||
(In reply to Yuren [:yurenju] from comment #7) > Comment on attachment 8415421 [details] [review] > github PR > > that's a good idea for separating profile-debug and profile for gaia-test, > thanks! > > and I have a question on github, please feel free to land it if it's not a > problem. You were right, I had a typo. I'm rebasing and waiting for a green travis.
Assignee | ||
Comment 9•10 years ago
|
||
master: ac6954ba11f1c059339c9f8b00864349b45140e5
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 10•10 years ago
|
||
Landed a follow-up to add the new folders into the .gitignore file: https://github.com/mozilla-b2g/gaia/commit/fe8b1e650712819d8bf06e2d202d81ef248eb5eb
You need to log in
before you can comment on or make changes to this bug.
Description
•