980567 - [B2G][Notifications API] Relative icon URLs aren't shown correctly in status bar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[sarsenyev]

Attachment: 2014-03-06-13-51-15.png

Description:
When selecting "Show Notification" with icon "qalogo" (no http), the logo is showing a broken image

Repro Steps:
1) Update a Buri to BuildID: 20140306040204
2) Open browser and go to http://mozqa.com/qa-testcase-data/webapi/notifications/index.html
3) after permission is granted select "qalogo.png" (no http)
4) Tap the "Show notification"
5) Slide down the status bar to see the notificaton

Actual:
The broken image logo appears in the status bar

Expected:
Valid logo with correct image is displayed in the status bar

1.4 Environmental Variables:
Device: Buri 1.4 MOZ
BuildID: 20140306040204
Gaia: 9cb35e701df44766d9b3560b0defe0a401a0ecdd
Gecko: 8122ffa9e1aa
Version: 30.0a1
Firmware Version: v1.2-device.cfg

Repro frequency: 100
Link to failed test case:https://moztrap.mozilla.org/manage/case/9932/
See attached: screenshot

Comment 1

[sarsenyev]

The issue reproduces with 1.3 and 1.2 Buri device

1.3 Environmental Variables:
Device: Buri 1.3 MOZ
BuildID: 20140306004002
Gaia: 8aed4fafbaeb86d6884d31ce7d3cbeb87bcbf837
Gecko: 3d2d84d52141
Version: 28.0
Firmware Version: v1.2-device.cfg

1.2 Environmental Variables:
Device: Buri 1.2 MOZ
BuildID: 20140220004002
Gaia: 539a25e1887b902b8b25038c547048e691bd97f6
Gecko: 2ea6a65eea23
Version: 26.0
Firmware Version: v1.2-device.cfg

Comment 2

[Jason Smith [:jsmith]]

Something tells me this is a bug in my test site.

Mike - Do you see anything obvious I'm not doing right here? I'm trying to include a relative icon URL for the icon in a notification.

Comment 3

[Michael Henretty [:mikehenrty][:mhenretty]]

Nope, I didn't see anything wrong in your test case, and relative URLS should work according to spec [1]. I would say this is a bug.

Also of note, it seems that if I first show a notification using the absolute URL, and then show a notification using the relative URL, the notification pop-up will show the old icon, but in the status bar it will show the broken image. Is this a known bug Jason?


1.) http://notifications.spec.whatwg.org/#constructors

Comment 4

[Darren]

The issue was reproduced in build below, some of the icons on the provided test site does not display icons.

Environmental Variables
Device: Buri v1.4 Aurora MOZ RIL
Build ID: 20140326000201
Gecko: https://hg.mozilla.org/releases/mozilla-aurora/rev/4889124accfa
Gaia: 7e705dd4718d528974d99ac31866318d7e201152
Platform Version: 30.0a2
Base Build: v1.2-device.cfg

Comment 5

[Frédéric Harper]

I got the same issue using local files too.

Comment 6

[Robert Bindar]

Attachment: icon_url_fix.patch

Comment 7

[Robert Bindar]

The URL is properly resolved there, we just need to actually pass it.

Comment 8

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8491668 [details] [diff] [review]
icon_url_fix.patch

LGTM

Comment 9

[Robert Bindar]

The try run is green.
https://tbpl.mozilla.org/?tree=Try&rev=6bf8d66b7b43

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/b19b42b1ef88

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b19b42b1ef88