980569 - Bookmark star animation is misaligned after fixing bug 975807

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

The fix for bug 975807 causes the bookmark star animation to end in the wrong place.

Comment 1

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: Patch v1

This patch changes the keyframes of the keyframes of the animation so that it fits nicely with the dropmarker. Tested on Linux (and OS X for side effects).

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8387127 [details] [diff] [review]
Patch v1

Review of attachment 8387127 [details] [diff] [review]:
-----------------------------------------------------------------

Tried, tested and true. This r+ is for you.

Thanks phlsa!

Comment 3

[Mike Conley (:mconley) (:⚙️)]

remote:   https://hg.mozilla.org/integration/fx-team/rev/043003505095

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/043003505095

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8387127 [details] [diff] [review]
Patch v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 

Bug 975807


User impact if declined: 

The bookmark star animation will be slightly misaligned, which looks sloppy.


Testing completed (on m-c, etc.): 

Local testing.


Risk to taking this patch (and alternatives if risky): 

Very, very low.


String or IDL/UUID changes made by this patch:

None.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/320a2301ab11