980625 - Plugin child leaks detected by LSAN

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Andrew McCreight [:mccr8]]

Attachment: m1plugins.txt

This is from an M1 run.  I don't know how important this might be.

Comment 1

[John Schoenick [:johns]]

There appear to be two leaks here, neither very serious:
- No destructor cleans up various things created in PluginModuleChild::Init. ModuleChild is 1:1 with the process so these isn't "really" a leak
- The test plugin, which is only used in the test suite, has a leak in scriptableHasProperty.

Comment 2

[John Schoenick [:johns]]

Attachment: Fix minor leak in nptest found by LSAN

Fixes the nptest leak

Comment 3

[John Schoenick [:johns]]

Attachment: Fix minor leak in PluginModuleChild::Init found by LSAN

Fixes Init leak - nsPluginFile is a struct, needs to have FreePluginInfo() called on it

Comment 4

[Andrew McCreight [:mccr8]]

for the record, one or both of these patches don't seem to build

Comment 5

[Andrew McCreight [:mccr8]]

This at least makes it compile (not actually a patch):
+++ b/dom/plugins/ipc/PluginModuleChild.cpp
@@ -182,7 +182,7 @@ PluginModuleChild::Init(const std::string& aPluginFilename,
-    FreePluginInfo(info);
+    pluginFile.FreePluginInfo(info);

Comment 6

[Andrew McCreight [:mccr8]]

These patches do fix the leaks I was seeing.  There's still this from the plugin process, but it is pretty useless:
Direct leak of 24 byte(s) in 1 object(s) allocated from:
    #0 0x440995 in malloc (/home/amccreight/ff-dbg-asan/dist/bin/plugin-container+0x440995)
    #1 0x7f023901ee08 in moz_xmalloc /home/amccreight/mc/memory/mozalloc/mozalloc.cpp:52

Comment 7

[John Schoenick [:johns]]

Attachment: Fix minor leak in PluginModuleChild::Init found by LSAN

Version that compiles

Comment 8

[John Schoenick [:johns]]

Attachment: Fix minor leak in PluginModuleChild::Init found by LSAN

Version that ACTUALLY compiles after I attached the same exact patch twice!

Comment 9

[Andrew McCreight [:mccr8]]

Here's another test plugin leak:

Direct leak of 835 byte(s) in 17 object(s) allocated from:
    #0 0x446395 in malloc /builds/slave/moz-toolchain/src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:74
    #1 0x7f5f48635b3d in moz_xmalloc /builds/slave/try-l64-asan-00000000000000000/build/memory/mozalloc/mozalloc.cpp:52
    #2 0x7f5f1a9e9d33 in c_str /builds/slave/try-l64-asan-00000000000000000/build/dom/plugins/test/testplugin/javaplugin/../nptest.cpp:1770
    #3 0x7f5f1a9e9d33 in getJavaCodebase(NPObject*, _NPVariant const*, unsigned int, _NPVariant*) /builds/slave/try-l64-asan-00000000000000000/build/dom/plugins/test/testplugin/javaplugin/../nptest.cpp:2914
    #4 0x7f5f1a9d5190 in scriptableInvoke(NPObject*, void*, _NPVariant const*, unsigned int, _NPVariant*) /builds/slave/try-l64-asan-00000000000000000/build/dom/plugins/test/testplugin/javaplugin/../nptest.cpp:2005
19   #5 0x7f5f404f6e66 in CallNPMethodInternal(JSContext*, JS::Handle<JSObject*>, unsigned int, JS::Value*, JS::Value*, bool) /builds/slave/try-l64-asan-00000000000000000/build/dom/plugins/base/nsJSNPRuntime.cpp:1393

Comment 10

[John Schoenick [:johns]]

Attachment: Strip trailing whitespace plague from nptest.cpp

It's everywhere!

Comment 11

[John Schoenick [:johns]]

Attachment: Fix more test plugin leaks found by LSAN

This macro expansion will double-evaluate NPN_StrDup and leak a string

Comment 12

[John Schoenick [:johns]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/763eb7c32075
https://hg.mozilla.org/integration/mozilla-inbound/rev/56ff5e931815
https://hg.mozilla.org/integration/mozilla-inbound/rev/a617b3b88132
https://hg.mozilla.org/integration/mozilla-inbound/rev/549cc0c0672f

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/763eb7c32075
https://hg.mozilla.org/mozilla-central/rev/56ff5e931815
https://hg.mozilla.org/mozilla-central/rev/a617b3b88132
https://hg.mozilla.org/mozilla-central/rev/549cc0c0672f