980652 - apitestbed app missing sometimes from the homescreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[bhargavg1]

See an issue sometimes that the apitestbed app though included in the build doesnt show-up on the hom-screen. 

Seems to be an issue with the icon resolution. Currently apitest bedapp has only 124 pixels icon can we add icons for 60 & 120 pixels as well

Comment 1

[Preeti Raghunath(:Preeti)]

Gregor,

Can you please review?

Making this a 1.4+ for QC CS.

Comment 2

[Gregor Wagner [:gwagner]]

I don't know what apitestbed app is.

Comment 3

[Jason Smith [:jsmith]]

Maybe this - https://github.com/geoelectric/apitest?

Comment 4

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

I never added that to the build.

Comment 5

[Jason Smith [:jsmith]]

mvines - So we don't have a clue what this apitestbed app is. Can you clarify what's being tested here?

Comment 6

[Michael Vines [:m1] [:evilmachines]]

Yeah, it's https://github.com/geoelectric/apitest

We have this app added to the build for testing purposes.

Comment 7

[Gregor Wagner [:gwagner]]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #6)
> Yeah, it's https://github.com/geoelectric/apitest
> 
> We have this app added to the build for testing purposes.

I don't think we can do much here without access to the code.

Comment 8

[Jason Smith [:jsmith]]

(In reply to Gregor Wagner [:gwagner] from comment #7)
> (In reply to Michael Vines [:m1] [:evilmachines] from comment #6)
> > Yeah, it's https://github.com/geoelectric/apitest
> > 
> > We have this app added to the build for testing purposes.
> 
> I don't think we can do much here without access to the code.

What code? We've got access to that repository.

Comment 9

[Michael Vines [:m1] [:evilmachines]]

Yeah, it's Geo's app. :)

Comment 10

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #6)
> Yeah, it's https://github.com/geoelectric/apitest
> 
> We have this app added to the build for testing purposes.

Michael,

This was never meant to be included as part of any official build. It certainly shouldn't be in a release build, so 1.4+ seems inappropriate.

Pulling in Clint for specific comment here.

Comment 11

[cmtalbert]

Ok, so this is trivial, so here's a PR: https://github.com/geoelectric/apitest/pull/7.

But in the grander scheme of things, what are you using this for? We are working on a replacement for OEM style web API testing that is more conclusive and in line with our branding requirements, and you should probably using that going forward. In the meantime, Geo's code is complete and is stable, so I can understand keeping that for the time being. But, do know that we're not maintaining it going forward since we're doubling down in other areas.

Comment 12

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

I will be interested to know whether adding the other icon sizes fixes things re: it not appearing. AFAIK, only the 128px one is required, and then it should (at various levels of "looks good") resize from there.

"For the actual on-device icon; only the 128px icon is mandatory, but it is recommended to include [60px] as well for optimal device icon display"

https://developer.mozilla.org/en-US/Apps/Build/Manifest

The other possible source of issue might be how the app was added to the build process itself.

Comment 13

[Jason Smith [:jsmith]]

How is this app being included in the build? Are you doing this via a distribution directory via customization? Directly in the apps directory?

Comment 14

[Michael Vines [:m1] [:evilmachines]]

The app is only added to our internal builds, as it contains some useful functions for test teams.  If there's an alternative app that we should use instead we are totally fine with switching to that.  Let us know when it's ready and where it is.

Adding another app icon to the app manifest is one way to fix this bug, a better way might be to understand why the homescreen is disappearing the app with the existing manifest (which is really more of the reasoning behind why this bug was opening)

Comment 15

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #14)

> Adding another app icon to the app manifest is one way to fix this bug, a
> better way might be to understand why the homescreen is disappearing the app
> with the existing manifest (which is really more of the reasoning behind why
> this bug was opening)

This is why I'm hoping for followup regarding whether adding the icons actually helped. The original report said there was an intermittent problem, and additionally asked us whether we could add the other icon resolutions as a guess as to what would help. But if it doesn't help, then the problem could be completely unrelated.

I'll ask around, but this isn't a general problem I've seen on our builds or devices. But as I mentioned above, there is a custom build process happening, given that this app isn't in our builds. It seems plausible that this could be at least a factor in the issue. Outlining how it's being added might help.

Comment 16

[Michael Vines [:m1] [:evilmachines]]

(In reply to Geo Mealer [:geo] from comment #15)
> But as I mentioned above, there is a custom build process
> happening, given that this app isn't in our builds. It seems plausible that
> this could be at least a factor in the issue. Outlining how it's being added
> might help.

Custom build process is simply adding more apps to the build, like this app.  The GAIA_OUTOFTREE_APP_SRCDIRS env variable is defined to the root of the external app root.  This hasn't changed since v1.0

Comment 17

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

(In reply to Michael Vines [:m1] [:evilmachines] from comment #16)

> Custom build process is simply adding more apps to the build, like this app.
> The GAIA_OUTOFTREE_APP_SRCDIRS env variable is defined to the root of the
> external app root.  This hasn't changed since v1.0

Cool, thanks for clarifying!

Comment 18

[Jason Smith [:jsmith]]

Given that the one way to fix this bug is implemented, I'm going to close this bug.

If we do end up seeing this app not showing up issue on production builds (either QA builds or partner builds), then we can look into the other issue with the app not showing up in a different bug.

Comment 19

[Brogan Zumwalt [Inactive]]

Does not appear to be something that we would test. Test case unnecessary.