980670 - [BURI] 'SIM 1' shown under STK carrier label

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: STKwithSIM1onBURI.png

Build Information

Device: Buri
Build ID: 20140306134106
Platform Version: 30.0a1
Gaia      98cf46d6623b164845fe1fdc99a2a7bf64aa667d                         │
Gecko     https://hg.mozilla.org/mozilla-central/rev/8095b7dd8f58          │
BuildID   20140306134106                                                   │
Version   30.0a1                                                           │
ro.build.version.incremental=eng.archermind.20131114.105818  



Description



Steps to Reproduce

1. Open "Settings" -> Scroll to the bottom -> check "STK"

Expected Results:
Spec? 

Actual Results:
"SIM 1" appears under carrier label
Not in 20130305 build
Other Notes

Reproduction Frequency: always

Comment 1

[Preeti Raghunath(:Preeti)]

UX

Doesn't seem like a blocker. Your take, please?

Comment 2

[Stephany Wilkes]

Flagging Carrie on whether or not to block. Sorry this is late.

Comment 3

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

This string is allways showed:

https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/icc_menu.js#L76

We can avoid showing it if only one SIM card is listed

Comment 4

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Attachment: Proposed patch

Comment 5

[Maria Angeles Oteo (:oteo)]

According to the DSDS specs for all applications in a single SIM device we should not show SIM1 or SIM2 strings (just SIM) so the end User should not notice that DSDS has landed in v1.4.

If I am not wrong this bug has been reported in a buri(single SIM device), so iMHO we should block the release to mantain the consistency.

Comment 6

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

 (In reply to Maria Angeles Oteo (:oteo) on PTO until 04/24 from comment #5)
> According to the DSDS specs for all applications in a single SIM device we
> should not show SIM1 or SIM2 strings (just SIM) so the end User should not
> notice that DSDS has landed in v1.4.
> 
> If I am not wrong this bug has been reported in a buri(single SIM device),
> so iMHO we should block the release to mantain the consistency.

Hi M.A.,

Should we write the string "SIM" bellow the carrier name?

With the proposed patch, this string is not showed on single sim devices (only carrier name) and SIM 1 & SIM 2 are showed bellow each carrier name in DSDS devices.

Comment 7

[Eric Chang [:ericcc] [:echang]]

Hi, Arthur, could you help with this review, thank you.

(In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from comment #4)
> Created attachment 8406699 [details] [review]
> Proposed patch

Comment 8

[Noemí Freire (:noemi)]

(In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from comment #6)
>  (In reply to Maria Angeles Oteo (:oteo) on PTO until 04/24 from comment #5)
> > According to the DSDS specs for all applications in a single SIM device we
> > should not show SIM1 or SIM2 strings (just SIM) so the end User should not
> > notice that DSDS has landed in v1.4.
> > 
> > If I am not wrong this bug has been reported in a buri(single SIM device),
> > so iMHO we should block the release to mantain the consistency.
> 
> Hi M.A.,
> 
> Should we write the string "SIM" bellow the carrier name?
> 
> With the proposed patch, this string is not showed on single sim devices
> (only carrier name) and SIM 1 & SIM 2 are showed bellow each carrier name in
> DSDS devices.

I think this should be the expected behavior, no "SIM" tag for single SIM devices (as it currently works) just showing carrier name, ni to UX to confirm. Thanks!

Comment 9

[Maria Angeles Oteo (:oteo)]

(In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from comment #6)
>  (In reply to Maria Angeles Oteo (:oteo) on PTO until 04/24 from comment #5)
> > According to the DSDS specs for all applications in a single SIM device we
> > should not show SIM1 or SIM2 strings (just SIM) so the end User should not
> > notice that DSDS has landed in v1.4.
> > 
> > If I am not wrong this bug has been reported in a buri(single SIM device),
> > so iMHO we should block the release to mantain the consistency.
> 
> Hi M.A.,
> 
> Should we write the string "SIM" bellow the carrier name?
> 
> With the proposed patch, this string is not showed on single sim devices
> (only carrier name) and SIM 1 & SIM 2 are showed bellow each carrier name in
> DSDS devices.

Hi Fernando, For me it's the perfect solution! Anyway let's Omega to confirm it, the important thing is that SIM1/SIM2 should not appear so we avoid any confusion for single SIM devices users and providing them the same experience that they had before DSDS landing.

Comment 10

[Carrie Wang [New account: [e-mail]]]

hey there, 

If it's one SIM inserted (either single SIM devices or DSDS), we shouldn't display the SIM label. 
Thanks!

Comment 11

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

(In reply to Carrie Wang [:carrie] from comment #10)
> hey there, 
> 
> If it's one SIM inserted (either single SIM devices or DSDS), we shouldn't
> display the SIM label. 
> Thanks!

Cool, so the proposed patch work is expected :)
Thanks

Comment 12

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Thanks Vivien.

Landed: https://github.com/mozilla-b2g/gaia/commit/c8a41ca37677345d4dad2ccfc5145696b65a4686

Comment 13

[Eric Chang [:ericcc] [:echang]]

Verified okay on Buri.
Gaia      cadddcac2b8ce162a5e27e6dc105557b00a94478
Gecko     https://hg.mozilla.org/mozilla-central/rev/b681a6daea3b
BuildID   20140428160200
Version   32.0a1