980694 - [B2G][Bluetooth] Bluetooth will continue searching for an export device after it is disabled

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[Harvey]

Attachment: Bluetooth.png

Description:
The DuT will continue to search for a device to export via Bluetooth contacts to after Bluetooth has been disabled in the navigation bar.

Repro Steps:
1) Updated Buri to BuildID: 20140306040204
2) Enable Bluetootn and select the Contacts app.
3) Select the gear icon on the top right.
4) Select Export contacts and select Bluetooth.
5) Select some contacts and press Export.
6) Immediately press the Bluetooth icon on the navigation bar.

Actual:
The screen will continue to show "Searching for device" whilst Bluetooth is disabled

Expected:
The screen should notify the user that the Bluetooth is disabled is unable to search.

Environmental Variables:
Device: Buri v1.4 Mozilla
BuildID: 20140306040204
Gaia: 9cb35e701df44766d9b3560b0defe0a401a0ecdd
Gecko: 8122ffa9e1aa
Version: 30.0a1
Firmware Version: v1.2-device.cfg

Notes:

Repro frequency: 100%
See attached: Bluetooth.png

Comment 1

[Eric Chou [:ericchou] [:echou]]

cc Ian Liu

Ian, this seems to be another issue of inline pairing mechanism. Would you mind taking a look?

Comment 2

[Jason Smith [:jsmith]]

QA Wanted to check behavior on 1.3.

Comment 3

[[e-mail], [e-mail]]

This issue is not defined in inline pairing process spec. Once the issue is happened, a use is able to click device in list which are browsed before. Then, it will make device crash in Bluetooth disable mode. I have some solution in my mind to prevent a user go into this situation. But, it should be defined via UX input here. Need info. Omega. The attached file in this comment(https://bugzilla.mozilla.org/show_bug.cgi?id=949833#c22) are latest spec. definition. Thanks.

Comment 4

[[e-mail], [e-mail]]

Per offline discussion with Omega, there will be a dialog showing for confirmation(cancel/turn Bluetooth on), if a user turn Bluetooth off before choose a device to send file.

After a user confirmed the button, the flow would be:

Cancel: Cancel file send as clicked left-top "X" button.
Turn Bluetooth on: Re-update the devices list as a user just go into Bluetooth app.

The spec. will be updated later by Omega.

Nominating 1.4+ since it's a risk issue.

Comment 5

[Brogan Zumwalt [Inactive]]

Issue occurs on latest 1.3

Result:
The screen will continue to show "Searching for device" whilst Bluetooth is disabled

Environmental Variables:
Device: Buri v1.3 Mozilla RIL
BuildID: 20140310004001
Gaia: 78c30d7ed6f6e30337d6c05453b867f5e97e42bc
Gecko: 00f249d54bda
Version: 28.0
Firmware Version: v1.2-device.cfg

Comment 6

[Omega Feng [:Omega] [:馮於懋]]

Attachment: [Bluetooth] Inline pairing 0.5.pdf

Here is the updated spec.

Comment 7

[[e-mail], [e-mail]]

(In reply to Omega Feng [:Omega] from comment #6)
> Created attachment 8389008 [details]
> [Bluetooth] Inline pairing 0.5.pdf
> 
> Here is the updated spec.

In case of Appendix 4- Error handling (Turn off BT when inline paring), that's clear for me. Thanks for your updated.

Comment 8

[[e-mail], [e-mail]]

Attachment: pull request 17113

Alive, I'm not sure that you still have bandwidth to review the small patch.

This is an additional error handle flow. Since a user is able to show status bar in fullscreen app, then he/she is able to use utility tray for turning BT off during choose a device in Bluetooth app. According to user story, once a user turned BT off, then we will show the confirmation dialog for turn Bluetooth on again. Thanks.

Comment 9

[Preeti Raghunath(:Preeti)]

Please request this via the gaia approval flag.

Comment 10

[[e-mail], [e-mail]]

Comment on attachment 8389677 [details] [review]
pull request 17113

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 
A user is able to disable Bluetooth in utility tray during choose a device for file send.
[User impact] if declined: 
Will make platform crash.
[Testing completed]: 
None. Hard to add test case before refactor the code base.
[Risk to taking this patch] (and alternatives if risky): 
None.
[String changes made]: 
None.

Comment 11

[Jason Smith [:jsmith]]

Sorry for the confusion here Ian. What was meant by comment 9 was that this was not a blocker for 1.4, so this can land in 1.4 by default if this lands before 3/17. If it doesn't, then you'll need to get gaia approval for 1.4.

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8389677 [details] [review]
pull request 17113

I am not sure if I could r bluetooth app...had I?
BTW the code semantic looks a little strange to me, for example, use show(false) to mean hide.

Comment 13

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8389677 [details] [review]
pull request 17113

You need test!

Comment 14

[[e-mail], [e-mail]]

Comment on attachment 8389677 [details] [review]
pull request 17113

Tim, I have added unit test for the change patch. Could you please help to review? Thanks.

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8389677 [details] [review]
pull request 17113

Thank you.

Comment 16

[[e-mail], [e-mail]]

Since the pr is merged, we can close the issue now.

Gaia/master: de568b5ccb68188a645d39f2f4044a95eb3d48b0