Closed Bug 980699 Opened 8 years ago Closed 8 years ago

Bouncer submitter should print returned page content if hits a http error

Categories

(Release Engineering :: Release Automation: Other, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

Details

Attachments

(1 file)

Attached patch http.diffSplinter Review
No description provided.
Attachment #8387288 - Flags: review?
Comment on attachment 8387288 [details] [diff] [review]
http.diff

Review of attachment 8387288 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

::: scripts/bouncer_submitter.py
@@ +169,5 @@
> +            self.critical("Cannot access %s POST data:\n%s" % (api_url,
> +                                                               post_data))
> +            traceback.print_exc(file=sys.stdout)
> +            self.crititcal("Returned page source:")
> +            self.fatal(e.read())

TIL that HTTPError exception objects behave in a file like manner.
Attachment #8387288 - Flags: review? → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Typo followup https://hg.mozilla.org/build/mozharness/rev/8bca0b511a36:

-            self.crititcal("Returned page source:")
+            self.critical("Returned page source:")

in bouncer_submitter.py.
Ooops. Thanks for the fix.
You need to log in before you can comment on or make changes to this bug.