Closed
Bug 980699
Opened 10 years ago
Closed 10 years ago
Bouncer submitter should print returned page content if hits a http error
Categories
(Release Engineering :: Release Automation: Other, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: rail)
Details
Attachments
(1 file)
1.24 KB,
patch
|
hwine
:
review+
rail
:
checked-in+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8387288 -
Flags: review?
Comment 1•10 years ago
|
||
Comment on attachment 8387288 [details] [diff] [review] http.diff Review of attachment 8387288 [details] [diff] [review]: ----------------------------------------------------------------- lgtm ::: scripts/bouncer_submitter.py @@ +169,5 @@ > + self.critical("Cannot access %s POST data:\n%s" % (api_url, > + post_data)) > + traceback.print_exc(file=sys.stdout) > + self.crititcal("Returned page source:") > + self.fatal(e.read()) TIL that HTTPError exception objects behave in a file like manner.
Attachment #8387288 -
Flags: review? → review+
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8387288 [details] [diff] [review] http.diff remote: https://hg.mozilla.org/build/mozharness/rev/354247f45065 remote: https://hg.mozilla.org/build/mozharness/rev/8da0bb4416cc remote: https://hg.mozilla.org/build/mozharness/rev/26cd65055bac
Attachment #8387288 -
Flags: checked-in+
Assignee | ||
Updated•10 years ago
|
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Comment 3•10 years ago
|
||
Typo followup https://hg.mozilla.org/build/mozharness/rev/8bca0b511a36: - self.crititcal("Returned page source:") + self.critical("Returned page source:") in bouncer_submitter.py.
Assignee | ||
Comment 4•10 years ago
|
||
Ooops. Thanks for the fix.
You need to log in
before you can comment on or make changes to this bug.
Description
•