Closed
Bug 98074
Opened 25 years ago
Closed 25 years ago
Attachment manager doesn't html_escape bug titles.
Categories
(Bugzilla :: Attachments & Requests, defect, P1)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.16
People
(Reporter: timeless, Assigned: myk)
References
()
Details
Attachments
(1 file, 1 obsolete file)
|
992 bytes,
patch
|
caillon
:
review+
jacob
:
review+
|
Details | Diff | Splinter Review |
Must Fix for 2.14
erm, i'm asleep. 2.14 didn't include this thing...
Version: 2.14 → 2.15
| Assignee | ||
Comment 3•25 years ago
|
||
| Assignee | ||
Comment 4•25 years ago
|
||
| Assignee | ||
Updated•25 years ago
|
Attachment #48484 -
Attachment is obsolete: true
Updated•25 years ago
|
Comment 5•25 years ago
|
||
Comment on attachment 48488 [details] [diff] [review]
patch v2: does the escaping in the template rather than the perl
Myk, do we need these lines? They don't seem to make sense. Other than that, r=caillon
>+ title = title
>+ h1 = h1
>+ h2 = h2
Attachment #48488 -
Flags: review+
Comment 6•25 years ago
|
||
If this is TT I think this is saying we pass the var X in the current context as
the parameter X to the subform.
Comment 7•25 years ago
|
||
Comment on attachment 48488 [details] [diff] [review]
patch v2: does the escaping in the template rather than the perl
r=jake
The same thing also needs to be done on the View All page.
And yes, the title = title stuff is passing the varaible from edit.atml to global/header
Attachment #48488 -
Flags: review+
Comment 8•25 years ago
|
||
Zach checked this one in...
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Component: User Interface → attachment and request management
Updated•13 years ago
|
QA Contact: matty_is_a_geek → default-qa
You need to log in
before you can comment on or make changes to this bug.
Description
•