Closed Bug 980757 Opened 11 years ago Closed 6 years ago

[dsds] Location of SIM Security for DSDS

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: ericcc, Assigned: ashiue)

Details

Attachments

(1 file, 2 obsolete files)

PR 25163
46 bytes, text/x-github-pull-request
Bebe
: review-
Details | Review 
https://moztrap.mozilla.org/manage/cases/?filter-id=10665
https://moztrap.mozilla.org/manage/cases/?filter-id=10675
Check Sim Security is not under Settings, should be Sim Manager.
Check Accessing Call Settings has Sim picker shown.
https://moztrap.mozilla.org/manage/cases/?filter-id=10675
Check Accessing Call Settings has Sim picker shown.

--> recorded on bug:991518
Summary: [dsds] Items of Settings changed for DSDS → [dsds] Location of SIM Security for DSDS
Attached file PR 17939 (obsolete) — 

        Attachment #8401155 -
        Flags: review?(zcampbell)

        Attachment #8401155 -
        Flags: review?(fyen)

    
  

        Attachment #8401155 -
        Flags: review?(zcampbell)

        Attachment #8401155 -
        Flags: review?(fyen)

    
    

    
  
Sorry for the review request. 
I would apply another new git pull request later.

    
    

    
  

      
      
      
      

        Attached file
          
        PR 18060 (obsolete)
        — 
      

    


  

        Attachment #8401155 -
        Attachment is obsolete: true

    
  

        Attachment #8401155 -
        Flags: review?(zcampbell)

        Attachment #8401155 -
        Flags: review?(fyen)

    
  

        Attachment #8401155 -
        Flags: review?(zcampbell)

        Attachment #8401155 -
        Flags: review?(fyen)

    
  

        Attachment #8403044 -
        Flags: review?(zcampbell)

        Attachment #8403044 -
        Flags: review?(fyen)

    
    

    
  
comment on github

    
    

    
  
Comment on attachment 8403044 [details] [review]
PR 18060

Please follow pep8 to remove the whitespace

        Attachment #8403044 -
        Flags: review?(fyen) → review-

    
  

        Attachment #8403044 -
        Flags: review- → review?(fyen)

    
    

    
  
Comment on attachment 8403044 [details] [review]
PR 18060

Bebe or Bob, can you r? this when the Flame is working again?

Alison may need to rebase it.

        Attachment #8403044 -
        Flags: review?(zcampbell)

        Attachment #8403044 -
        Flags: review?(florin.strugariu)

        Attachment #8403044 -
        Flags: review?(bob.silverberg)

    
    

    
  
Comment on attachment 8403044 [details] [review]
PR 18060

r+ with a few cosmetic comments to be addressed. See the PR for details.

        Attachment #8403044 -
        Flags: review?(bob.silverberg) → review+

    
    

    
  
Comment on attachment 8403044 [details] [review]
PR 18060

Except for the comments nothing to add

        Attachment #8403044 -
        Flags: review?(florin.strugariu) → review+

    
    

    
  
Alison, can you rebase this pull request?
Flags: needinfo?(ashiue)

    
  
No longer blocks: 972263

    
    

    
  
Hi Zac,
I've updated the code with Bob's advice, please check the pr again.  Thank you!
Flags: needinfo?(ashiue)

        Attachment #8403044 -
        Flags: review?(fyen)

    
    

    
  
Looks like this pull was closed by autolander 

alison are you still working on it ?

Can you reopen it and r? me please
Flags: needinfo?(ashiue)

    
    

    
  

      
      
      
      

        Attached file
          
        PR 25163
        — 
      

    


  
Hi Florin, please review this PR, thanks.

        Attachment #8403044 -
        Attachment is obsolete: true

        Attachment #8505232 -
        Flags: review?(florin.strugariu)
Flags: needinfo?(ashiue)

    
    

    
  
Comment on attachment 8505232 [details] [review]
PR 25163

The pull looks good just some small updates and we are good to go....

        Attachment #8505232 -
        Flags: review?(florin.strugariu) → review-
QA Whiteboard: [fxosqa-auto-backlog+]

    
    

    
  
Alison, you're still working on this, I presume?
Assignee: nobody → ashiue
Flags: needinfo?(ashiue)

    
    

    
  
Put this task to low priority.
I would update it when I finish other tasks.
Flags: needinfo?(ashiue)

    
    

    
  
Firefox OS is not being worked on
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: