980789 - Fix failure of test_fmradio_add_remove_from_favorites.py and test_fmradio_frequency_dialer.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Askeing Yen[:askeing][:fyen]]

Buri
Gaia      98cf46d6623b164845fe1fdc99a2a7bf64aa667d
Gecko     https://hg.mozilla.org/mozilla-central/rev/8095b7dd8f58
BuildID   20140306160203
Version   30.0a1
ro.build.version.incremental=eng.archermind.20131114.105818
ro.build.date=Thu Nov 14 10:58:33 CST 2013

There is "JavascriptException: TypeError: window.navigator.mozFMRadio is undefined" when running FM test cases.

=====
Traceback (most recent call last):
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette_test.py", line 163, in run
testMethod()
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/tests/functional/fmradio/test_fmradio_add_remove_from_favorites.py", line 25, in test_add_remove_from_favorites
self.assertTrue(self.data_layer.is_antenna_available, 'Antenna (headphones) not plugged in')
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/gaiatest/gaia_test.py", line 302, in is_antenna_available
return self.marionette.execute_script('return window.navigator.mozFMRadio.antennaAvailable')
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette.py", line 1114, in execute_script
filename=os.path.basename(frame[0]))
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette.py", line 613, in _send_message
self._handle_error(response)
File "/var/lib/jenkins/jobs/B2G.master.pvt.hamachi.gaiatest/workspace/tests/python/gaia-ui-tests/.env/local/lib/python2.7/site-packages/marionette_client-0.7.5-py2.7.egg/marionette/marionette.py", line 648, in _handle_error
raise JavascriptException(message=message, status=status, stacktrace=stacktrace)
JavascriptException: JavascriptException: TypeError: window.navigator.mozFMRadio is undefined
stacktrace:
execute_script @gaia_test.py, line 302
inline javascript, line 1083
src: "let __marionetteFunc = function(){return window.navigator.mozFMRadio.antennaAvailable};__marionetteFunc.apply(null, __marionetteParams);"

Comment 1

[Askeing Yen[:askeing][:fyen]]

Attachment: PR 16978

wait FM is enabled after app is launched.

Comment 2

[Zac C (:zac)]

Comment on attachment 8387398 [details] [review]
PR 16978

nits about the timeouts.

Comment 3

[Askeing Yen[:askeing][:fyen]]

Comment on attachment 8387398 [details] [review]
PR 16978

Updated the commit :)

Comment 4

[Zac C (:zac)]

Comment on attachment 8387398 [details] [review]
PR 16978

r+

Comment 5

[Zac C (:zac)]

Merged:
https://github.com/mozilla-b2g/gaia/commit/f1d4d4c6d0e6079b2f7228a7ae849d4608e2c076