Closed Bug 98080 Opened 23 years ago Closed 23 years ago

ask for an attachment number when no params are given

Categories

(Bugzilla :: Attachments & Requests, enhancement, P3)

Product:
Bugzilla
Component:
Attachments & Requests
Version:
2.15
Platform:
Other
Other
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.16

People

(Reporter: timeless, Assigned: timeless)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

picky
854 bytes, patch
dkl
: review+
justdave
: review+
Details | Diff | Splinter Review 
    Error
You did not enter a valid attachment number.

Please press Back and try again.
-
that's nice, but
http://bugzilla.mozilla.org/show_bug.cgi gives:
Search by bug number
You may find a single bug by entering its bug id here: [      ]

which is _much_ nicer.
Attached patch port from show_bug.cgi (obsolete) — — Splinter Review 

    
    

    
  
Comment on attachment 48090 [details] [diff] [review]
port from show_bug.cgi

r=zach@zachlipton.com on the patch that timeless is about to attach. Someone please 2nd review.

        Attachment #48090 -
        Flags: review+

    
    

    
  
See also bug #87770.  There should be consistent error messages held in
globals.pl for these.
Priority: -- → P3
Target Milestone: --- → Bugzilla 2.16

    
    

    
  
Sorry, of course createattachment.cgi takes the bug number, not attachment
number.

    
    

    
  
Setting owner to patch writer.
Assignee: myk → timeless

    
    

    
  
Comment on attachment 48090 [details] [diff] [review]
port from show_bug.cgi

>+    print "You may find a single bug by entering its bug id here: \n";
Oops...                            ^^^                 ^^^

    
  

        Attachment #48090 -
        Flags: review-
Target Milestone: Bugzilla 2.16 → Bugzilla 2.18

    
    

    
  
We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        picky
        — 
          — Splinter Review
      

    


  

        Attachment #48090 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 58705 [details] [diff] [review]
picky

r=dkl, works great for me

        Attachment #58705 -
        Flags: review+

    
    

    
  
Comment on attachment 58705 [details] [diff] [review]
picky

works for me, though I'd point out that in bug 104521 and bug 109480 this whole
file is going away...

        Attachment #58705 -
        Flags: review+

    
    

    
  
checked in
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
fixing incorrect milestones on fixed bugs.
Target Milestone: Bugzilla 2.18 → Bugzilla 2.16

    
  
Component: Creating/Changing Bugs → attachment and request management
QA Contact: matty_is_a_geek → default-qa

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: