98080 - ask for an attachment number when no params are given

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, enhancement, P3)

Description

[timeless]

    Error
You did not enter a valid attachment number.

Please press Back and try again.
-
that's nice, but
http://bugzilla.mozilla.org/show_bug.cgi gives:
Search by bug number
You may find a single bug by entering its bug id here: [      ]

which is _much_ nicer.

Comment 1

[timeless]

Attachment: port from show_bug.cgi

Comment 2

[Zach Lipton [:zach]]

Comment on attachment 48090 [details] [diff] [review]
port from show_bug.cgi

r=[e-mail] on the patch that timeless is about to attach. Someone please 2nd review.

Comment 3

[Matthew Tuck [:CodeMachine]]

See also bug #87770.  There should be consistent error messages held in
globals.pl for these.

Comment 4

[Matthew Tuck [:CodeMachine]]

Sorry, of course createattachment.cgi takes the bug number, not attachment
number.

Comment 5

[Jacob Steenhagen]

Setting owner to patch writer.

Comment 6

[Jacob Steenhagen]

Comment on attachment 48090 [details] [diff] [review]
port from show_bug.cgi

>+    print "You may find a single bug by entering its bug id here: \n";
Oops...                            ^^^                 ^^^

Comment 7

[Dave Miller [:justdave]]

We are currently trying to wrap up Bugzilla 2.16.  We are now close enough to
release time that anything that wasn't already ranked at P1 isn't going to make
the cut.  Thus this is being retargetted at 2.18.  If you strongly disagree with
this retargetting, please comment, however, be aware that we only have about 2
weeks left to review and test anything at this point, and we intend to devote
this time to the remaining bugs that were designated as release blockers.

Comment 8

[timeless]

Attachment: picky

Comment 9

[David Lawrence [:dkl]]

Comment on attachment 58705 [details] [diff] [review]
picky

r=dkl, works great for me

Comment 10

[Dave Miller [:justdave]]

Comment on attachment 58705 [details] [diff] [review]
picky

works for me, though I'd point out that in bug 104521 and bug 109480 this whole
file is going away...

Comment 11

[timeless]

checked in

Comment 12

[Dave Miller [:justdave]]

fixing incorrect milestones on fixed bugs.