980819 - [B2G][Email] The text and button has not align center in IMAP disable page

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P3)

Description

[Edward Chen[:edchen]]

Attachment: Text as well as button has not center-text.

[Environment]

Gaia      71f78f7f68fcf5e23cc5965fee0dad45289c438b
Gecko     https://hg.mozilla.org/mozilla-central/rev/5dc091b7e86f
BuildID   20140304160205
Version   30.0a1

[Steps]
1. Launch email app and set a gmail account with Gmail.
2. Make sure that it can receive mails.
3. Go desktop of gmail setting to disable IMAP.
4. Close email app
5. Launch email app again, and then waiting for 1 min. 
6. Show "IMAP Disable" page.

[Actual result]
The text as well as button has not center-text.

[Expect result]
The text as well as button has center-text.

Comment 1

[Edward Chen[:edchen]]

[Devices]
Flame

[Environment]
Gaia      8d865839d932bfbd5e157f376f74d8cb12bfdd51
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/1d4046a8cb6c
BuildID   20140610000223
Version   32.0a2
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

Comment 2

[Dylan Oliver [:doliver]]

blocking -- small visual issue with visual refresh

Comment 3

[James Burke [:jrburke]]

Attachment: GitHub pull request

Some other error screens were also not up to date with the new visual design, so I also updated them:

* gmail two-factor
* bad password
* imap/pop3 disabled


I tested them by using these commands in the devtools console:

require('api').onbadlogin(require('model').account, 'imap-disabled');
require('api').onbadlogin(require('model').account, 'bad-user-or-pass');
require('api').onbadlogin(require('model').account, 'needs-app-pass');

I will attach a screenshot of how they look now.

Comment 4

[James Burke [:jrburke]]

Attachment: error-screens.png: how the error dialogs look now with the fixes

Comment 5

[Marcus Cavanaugh [:mcav]]

Comment on attachment 8441658 [details] [review]
GitHub pull request

woo, thanks for the screenshots! r=mcav

Comment 6

[James Burke [:jrburke]]

Fixed in master:
https://github.com/mozilla-b2g/gaia/commit/5dd00099cce59c53c42f74a261c97cd41887419d

from pull request:
https://github.com/mozilla-b2g/gaia/pull/20635

Comment 7

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/230866688509108b9a5be6bddd14597b486b7a6e

Comment 8

[Edward Chen[:edchen]]

[Environment]
Gaia      23e06c3624309db22ad9cb736d89700768b42b36
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/12161a842a8e
BuildID   20140618160200
Version   32.0a2
ro.build.version.incremental=94
ro.build.date=Tue May 20 09:29:20 CST 2014

[Result]
Pass

Comment 9

[Sue]

Attachment: verify_video

This issue has been verified successfully on Flame v2.1
See attachment: verify_video.mp4
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.034738
FW-Date         Sun Nov 30 03:47:49 EST 2014
Bootloader      L1TC00011880