Closed Bug 980885 Opened 6 years ago Closed 6 years ago

Fix more Moz2D D2D mapping code that fails to set/reset mIsMapped

Categories

(Core :: Graphics, defect)

29 Branch
x86
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

Attachments

(1 file)

Similar to bug 980272, there is more D2D code that forgets to set mIsMapped. This blocks bug 980436 which makes us actually call the buggy Map/Unmap methods.
Attached patch patchSplinter Review
Attachment #8387553 - Flags: review?(bas)
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee113a965f7a

Bug 979394 added yet another broken return point yesterday, which I went ahead and fixed in this push.
Attachment #8387553 - Flags: review?(bas) → review+
Also blocks bug 980547 since that too adds a Map/Unmap call that hits this code.
Blocks: 980547
Commit https://hg.mozilla.org/integration/mozilla-inbound/rev/ee113a965f7a has the wrong commit message. It should be for bug 980547.
Bas, can you take a look at the mMapped members in the various Map/Unmap implementations too? It's not clear at first glance what they're for, but I'm wondering if we're not setting/resetting that member correctly too.
Flags: needinfo?(bas)
https://hg.mozilla.org/mozilla-central/rev/ee113a965f7a
https://hg.mozilla.org/mozilla-central/rev/7e787cc4649e
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla30
Flags: needinfo?(bas)
You need to log in before you can comment on or make changes to this bug.