980885 - Fix more Moz2D D2D mapping code that fails to set/reset mIsMapped

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

Similar to bug 980272, there is more D2D code that forgets to set mIsMapped. This blocks bug 980436 which makes us actually call the buggy Map/Unmap methods.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ee113a965f7a

Bug 979394 added yet another broken return point yesterday, which I went ahead and fixed in this push.

Comment 3

[Jonathan Watt [:jwatt]]

Also blocks bug 980547 since that too adds a Map/Unmap call that hits this code.

Comment 4

[Jonathan Watt [:jwatt]]

Commit https://hg.mozilla.org/integration/mozilla-inbound/rev/ee113a965f7a has the wrong commit message. It should be for bug 980547.

Comment 5

[Jonathan Watt [:jwatt]]

Now actually committed in https://hg.mozilla.org/integration/mozilla-inbound/rev/7e787cc4649e

Comment 6

[Jonathan Watt [:jwatt]]

Bas, can you take a look at the mMapped members in the various Map/Unmap implementations too? It's not clear at first glance what they're for, but I'm wondering if we're not setting/resetting that member correctly too.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ee113a965f7a
https://hg.mozilla.org/mozilla-central/rev/7e787cc4649e