980907 - [ml, mr, kn, mai, ta, te, bn-IN, gu-IN, as, or] Add Indic locales to Fennec all-locales

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jeff Beatty [:gueroJeff]]

Currently pa-IN and hi-IN are already in Fennec all-locales. Please add the remaining Indic locales to mobile/android/locales/all-locales in order to allow them to test and track l10n work on Fennec.

Comment 1

[Jeff Beatty [:gueroJeff]]

Attachment: Patch to add Indic locales to mobile/android/locales/all-locales

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or IDL/UUID changes made by this patch:

Comment 2

[Axel Hecht [:Pike]]

Comment on attachment 8387575 [details] [diff] [review]
Patch to add Indic locales to mobile/android/locales/all-locales

Review of attachment 8387575 [details] [diff] [review]:
-----------------------------------------------------------------

r-, as this patch actually conflicts with bug 979260, which adds just 'ms'.

Canceling the other flags, too. Just talked to RyanVM on irc, the best way to get your patches landed is to request checkin after the patch has review and approval. Don't flag me in person, and one of us is gonna get to it.

Comment 3

[Jeff Beatty [:gueroJeff]]

(In reply to Axel Hecht [:Pike] from comment #2)
> Comment on attachment 8387575 [details] [diff] [review]
> Patch to add Indic locales to mobile/android/locales/all-locales
> 
> Review of attachment 8387575 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r-, as this patch actually conflicts with bug 979260, which adds just 'ms'.
> 
> Canceling the other flags, too. Just talked to RyanVM on irc, the best way
> to get your patches landed is to request checkin after the patch has review
> and approval. Don't flag me in person, and one of us is gonna get to it.

Sounds good. I've added 979260 as a blocker to this bug so that I can request a review once the patch from 979260 lands.

Thank you!

Comment 4

[Jeff Beatty [:gueroJeff]]

Comment on attachment 8387575 [details] [diff] [review]
Patch to add Indic locales to mobile/android/locales/all-locales

Review of attachment 8387575 [details] [diff] [review]:
-----------------------------------------------------------------

Now that 979260 has landed, I'm flagging patch for new review.

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 8387575 [details] [diff] [review]
Patch to add Indic locales to mobile/android/locales/all-locales

Review of attachment 8387575 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, but we'll need a new patch that doesn't try to add 'ms'. I expect that you'll get a merge conflict to resolve when you hg pull --rebase in your aurora repo.

PS: I would have just cleared the review if the patch had a chance to survive.

Comment 6

[Jeff Beatty [:gueroJeff]]

Attachment: [updated] Patch to add Indic locales to mobile/android/locales/all-locales

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: 
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): 
String or IDL/UUID changes made by this patch:

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0ffbd3bdf694

Comment 8

[Ioana Chiorean]

TCs added in Moztrap:

Assamese (as): https://moztrap.mozilla.org/manage/case/13888/
Bengali (bn-IN): https://moztrap.mozilla.org/manage/case/13879/
Gujarati (gu-IN): https://moztrap.mozilla.org/manage/case/13880/
Kannada (kn): https://moztrap.mozilla.org/manage/case/13881/
Maithili (mai): https://moztrap.mozilla.org/manage/case/13882/
Marathi (mr): https://moztrap.mozilla.org/manage/case/13883/
Malayalam (ml): https://moztrap.mozilla.org/manage/case/13884/
Oriya (or): https://moztrap.mozilla.org/manage/case/13885/
Tamil (ta): https://moztrap.mozilla.org/manage/case/13886/
Telugu (te): https://moztrap.mozilla.org/manage/case/13887/