980975 - [Australis] Free Games 3.4 throws all removable items out of the nav-bar on browser start.

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Just tested some randomly selected add-ons, and noticed this one does the evil thing of chucking all non-removable items out of the nav-bar.

This is probably because the add-on is iterating the direct children of the nav-bar, and manually setting currentset on it. Since the direct children of the nav-bar is no longer the toolbar items, but rather the customization target and some other things, the add-ons assumptions are busted.

We really need to get our AMO editors to scan for add-ons that attempt to iterate the nav-bar (or any toolbar's) children, and mark them as incompatible. They should either use CustomizableUI to get the placements in the toolbar, or else iterate the children of toolbar.customizationTarget.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Link to the add-on in question: https://addons.mozilla.org/en-US/firefox/addon/free-games/

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

The developer has been notified.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

This add-on was marked as incompatible. Nothing left to do here.