981033 - Fix intermittent "chrome/test_cyclecollector.xul | Observer should have been called!" failure with ICC

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: test log, nothing very useful here

Comment 2

[Andrew McCreight [:mccr8]]

Attachment: failure log for test_aboutmemory6.xul

I don't like the look of this intermittent failure, either.

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: Clear mActivelyCollecting before restarting CC.

I think this is a silly mistake.  The scenario is triggering a full CC when we're in the middle of an ICC.  At the start of Collect(), it sets the reentrancy guard, then finishes off the ICC that is in progress.  Then it recusively invokes Collect() again, to do the full CC, but the reentrancy guard is already set, so we return immediately.  To fix this, I just clear the reentrancy guard before we check if we need a recursive call.  All the real CC work is still guarded by the flag, so it should be okay.

Comment 4

[Andrew McCreight [:mccr8]]

Well, I should do a try run first, just in case.

Comment 5

[Andrew McCreight [:mccr8]]

try run: https://tbpl.mozilla.org/?tree=Try&rev=8aa91b4a24a5

Comment 6

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/07f677730558

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/07f677730558