981035 - Enable ASAN tests on the Jetpack tree

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

The JP tests on Linux ASAN builds on trunk trees have been hidden in bug 980997 for failing too frequently. Currently, the Jetpack tree does not run against ASAN builds, thus fixing up the tests so they can be unhidden will be more difficult (pushing to try means we have to build ASAN Firefox from scratch, while pushing to the Jetpack tree would just use a recent ASAN binary from the fx-team tree).

Comment 1

[Phil Ringnalda (:philor)]

Attachment: [configs] add it

Wow, I never thought I'd be fast enough to be able to grab such a plum assignment.

My theory is that these totally untested patches have about equal chances of doing nothing at all, adding the job busted, and completely busting buildbot. Less sure how the odds of them working compare to those three.

Comment 2

[Phil Ringnalda (:philor)]

Attachment: [tools] find it

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 8395441 [details] [diff] [review]
[tools] find it

https://hg.mozilla.org/build/tools/rev/b5becc62d2cc

Comment 4

[Phil Ringnalda (:philor)]

Comment on attachment 8395440 [details] [diff] [review]
[configs] add it

https://hg.mozilla.org/build/buildbot-configs/rev/cdfe5970c868

Comment 5

[Chris AtLee [:catlee]]

Attachment: don't do it

Comment 6

[Chris AtLee [:catlee]]

(In reply to Chris AtLee [:catlee] from comment #5)
> Created attachment 8396648 [details] [diff] [review]
> don't do it

to stop running debug tests where people say silly things like debug: False in the configs

Comment 7

[[e-mail] (:bhearsum)]

something is in production

Comment 8

[Aki Sasaki (not active)]

Comment on attachment 8396648 [details] [diff] [review]
don't do it

I don't grok the problem, but the patch looks harmless.

Comment 9

[Justin Wood (:Callek)]

Comment on attachment 8396648 [details] [diff] [review]
don't do it

This patch is now live