981125 - Wrong menupopup positioning in "Plugins" in the Addon Manager with certain CSS-rules

Status: UNCONFIRMED

(Core :: XUL, defect, P5)

Description

[Elbart]

Attachment: userContent.css

I'm using the addon "Cleanest Addon Manager"[1] to get change the styling of about:addons. It's working fine, except of the menupopups in "Plugins", which are all over the place.

I've tinkered with the addon and cut its styles down to a simple testcase, see attachment.

===

STR:
- Create a folder called "chrome" in the profile, and copy userContent.css into it
- Start Firefox
- Go into the Plugins-section of the Addon Manager and open any menulist

ER:
The menupopup is right below the menulist-element

AR:
The menupopup is all over the place, probably depending on the sizes of the other elements, see top part of the screenshot: http://i.imgur.com/0wxSlp1.png

===

When any one of the two relevant width-percentages are changed to a px- or em-setting, the menupopup is aligned properly with the menulist-button. But of course the final design is way off, compared to what it's supposed to look like: http://i.imgur.com/1K0J7hH.png


[1] https://addons.mozilla.org/en-US/firefox/addon/cam/

Comment 1

[Elbart]

Attachment: userContent.css

Comment 2

[Mats Palmgren (inactive)]

Sorry, but this is not the place to get help with add-ons or bugs that you
introduce yourself with userContent.css.

Comment 3

[Boris Zbarsky [:bzbarsky]]

But note also that XUL boxes handle percentages in _really_ weird ways...

Comment 4

[Elbart]

(In reply to Mats Palmgren (:mats) from comment #2)
> Sorry, but this is not the place to get help with add-ons or bugs that you
> introduce yourself with userContent.css.
Nice, thank you.

Turns out, the problem lies with XUL: https://bugzilla.mozilla.org/show_bug.cgi?id=433037

So this can be marked as duplicate, I guess.

Comment 5

[Elbart]

Attachment: screen_recording.gif

So if I'm understanding correctly: A few css-rules, which aren't even touching menulist/menupopup, are supposed to be causing phantom-mouseover-events and it's actually not a bug of the browser?

Comment 6

[Elbart]

Attachment: plugins.xul

After tinkering around with the style and DOM Inspector, I found out that when I set "flex" to "0" for the elements "description-outer-container" and "content-inner-container", the menupopup is properly positioned below the menulist-button.


So I stripped down extensions.xul to the bare minimum and found out that the bug happens when
- there is a <spacer> in front of a menulist (like on about:addons 
  "Plugins")(menulist can be in a hbox or not)
- those two being within a hbox with width:50%, for example
- and that hbox being in a hbox with "display" set to either block or 
  inline-block, or inline-table or table when also setting width to 100%.

To test the attached testcase, download it to your HD, create the boolean "dom.allow_XUL_XBL_for_file" in about:config and set it to true, and then drag the xul-file into the browser.

As a dirty hacky workaround "display" has to be added as a style to the hbox holding the affected menulist with any of the four aforementioned values.
If the menulist is located directly in the child-hbox, this workaround does not work.

Please consider reopening this bug, as the root-problem is not in CSS but XUL.

Comment 7

[Elbart]

Attachment: last fully working version 2007-07-04-03.png

The regression-range for the menupopup-misplacement:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-07-04-04&maxdate=2007-07-05-04&cvsroot=%2Fcvsroot

Good nightly: 2007-07-04-04
Bad nightly: 2007-07-05-04
Probably https://bugzilla.mozilla.org/show_bug.cgi?id=279703#c88.
http://hg.mozilla.org/mozilla-central/rev/d9b35fd9b4bf

The regression-range for the phantom-mouse-highlight-area (but not on the misplaced menupopup:

Good: 2008-09-03-03
Bad: 2008-09-04-03
Maybe bug 453531 http://hg.mozilla.org/mozilla-central/rev/45f3fc5a40f3

The regression range for mouseover-highlights registering on both the misplaced menupopup and where it's supposed to be:

Last good revision: baec1efc87a4 (2012-03-04)
First bad revision: 433cfbd2a0da (2012-03-05)
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=baec1efc87a4&tochange=433cfbd2a0da
Maybe bug 664707.

Comment 8

[[e-mail]]

Comment on attachment 8387862 [details]
userContent.css

XUL has never really been happy with HTML display types. Maybe once it gets converted to flexbox then things will start working. In the mean time, you could try using the following styles instead:

.content-inner-container {
  -moz-box-orient: horizontal;
}

.basicinfo-container, .advancedinfo-container {
  width: 1px;
  -moz-box-flex: 1;
}

Comment 9

[Timothy Nikkel (:tnikkel)]

There is a decent chance this got fixed by bug 1130400 is anyone wants to test.