981261 - Rename nsEventListener* to mozilla::EventListener*

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.1 Rename nsEventListener(Service|Info) to mozilla::EventListener(Service|Info)

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.2 Rename nsListenerStruct to nsEventListenerManager::Listener

nsListenerStruct is used only in nsEventListenerManager and inline method only for it.

So, for making clearer the fact, let's move it into nsEventListenerManager since the header file is exported and referred by a lot of developers who are not familiar with nsEventLinsterManager.

Then, the name can be simple. I think it's actual instance of event listener. Therefore, I name it just "Listener". See also part.6. Part.6 patch renames the variables of Listener, nsIJSListener, nsIDOMEventListener and EventListenerHolder for easy to read.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.3 Rename nsListenerType to nsEventListenerManager::Listener::ListenerType

nsListenerType defines the type of nsEventListenerManager::Listener (nsListenerStruct). I.e., it's clearer if it's defined in nsEventListenerManager::Listener. I don't change the each value name because I have no better idea. "Listener" is redundant to me, though.

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.4 Move EventListenerFlags from mozilla::dom:: to mozilla::

One of our rules of this series of bugs is, class representing DOM class should be mozilla::dom::<name in standard spec> and the others should be mozilla::foo.

So, mozilla::dom::EventListenerFlags should be moved to mozilla:: for the consistency with other classes.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.5 Rename nsEventListenerManager to mozilla::EventListenerManager

This also fixes some include hell :-(

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.6 Sort out variable names of EventListenerManager::Listener, EventListenerHolder, nsIJSEventListener and nsIDOMEventListener in EventListenerManager.cpp

Let's use specific variable names for the similar types. By this, other developers can distinguish without checking the definition.

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8390295 [details] [diff] [review]
part.2 Rename nsListenerStruct to nsEventListenerManager::Listener


>+    nsIJSEventListener* GetJSListener() const {
{ to the next line

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8390299 [details] [diff] [review]
part.5 Rename nsEventListenerManager to mozilla::EventListenerManager

Don't know why HTMLSelectElement.cpp needs BasicEvents.h, but I assume it is ok.
Same with #include "js/Tracer.h" in nsXULElement.h.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b604111dc9d6
https://hg.mozilla.org/integration/mozilla-inbound/rev/95a8536c310a
https://hg.mozilla.org/integration/mozilla-inbound/rev/4166d9d87a05
https://hg.mozilla.org/integration/mozilla-inbound/rev/e0b529437af0
https://hg.mozilla.org/integration/mozilla-inbound/rev/84f11c295ae3
https://hg.mozilla.org/integration/mozilla-inbound/rev/f3f677c84bf2

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b604111dc9d6
https://hg.mozilla.org/mozilla-central/rev/95a8536c310a
https://hg.mozilla.org/mozilla-central/rev/4166d9d87a05
https://hg.mozilla.org/mozilla-central/rev/e0b529437af0
https://hg.mozilla.org/mozilla-central/rev/84f11c295ae3
https://hg.mozilla.org/mozilla-central/rev/f3f677c84bf2