Closed
Bug 98128
Opened 24 years ago
Closed 24 years ago
inline some stuff used by SelectorMatches
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla0.9.6
People
(Reporter: dbaron, Assigned: dbaron)
Details
(Keywords: perf, Whiteboard: [whitebox])
Attachments
(1 file)
|
1.27 KB,
patch
|
Details | Diff | Splinter Review |
A few functions used by SelectorMatches are called in only one place, so
inlining would almost definitely be a gain.
|
Assignee | |
Comment 1•24 years ago
|
||
|
|
Assignee | |
Updated•24 years ago
|
|
||
Comment 2•24 years ago
|
||
The normal questions, are the functions really inlined, and what does it do to
the code size?
|
|
Assignee | |
Comment 3•24 years ago
|
||
While I'm here, I should remove the second |mRuleCascades = nsnull;| that was
added in the patch for bug 93977.
|
|
Assignee | |
Updated•24 years ago
|
Target Milestone: mozilla0.9.5 → mozilla0.9.6
|
|
Assignee | |
Comment 5•24 years ago
|
||
BTW, the functions that I inlined are only used in one place, so it's
practically guaranteed to reduce code size...
|
|
Assignee | |
Comment 6•24 years ago
|
||
This was checked in with the patch to bug 56117 at 2001-10-29 22:02 PDT.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
|
|
||
Updated•23 years ago
|
Whiteboard: [whitebox]
You need to log in
before you can comment on or make changes to this bug.
Description
•