Closed
Bug 981333
Opened 11 years ago
Closed 11 years ago
Update Fake for the normalize method
Categories
(Instantbird Graveyard :: Other, defect)
Instantbird Graveyard
Other
Tracking
(Not tracked)
RESOLVED
FIXED
1.6
People
(Reporter: clokep, Assigned: clokep)
Details
Attachments
(1 file)
|
1.66 KB,
patch
|
florian
:
review+
|
Details | Diff | Splinter Review |
When we added the normalize method in bug 955553 we never updated Fake. I did this before 1.5, but the patch is pretty rough.
|
Assignee | |
Comment 1•11 years ago
|
||
Honestly I haven't tried this in a long time, but I don't think we've changed any other interfaces recently.
This also changes a minor bug where a variable is referenced that doesn't exist.
Attachment #8388116 -
Flags: review?(florian)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8388116 [details] [diff] [review]
Update fake
Review of attachment 8388116 [details] [diff] [review]:
-----------------------------------------------------------------
The code change here is reasonable but your comment 1 here doesn't give me confidence you've actually tested that Fake works after this change. Can you check it before the check-in? Thanks!
Attachment #8388116 -
Flags: review?(florian) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Got my Windows debug build working again and tested this. It works fine! Thanks for the review.
Keywords: checkin-needed
|
||
Comment 4•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Target Milestone: --- → 1.6
You need to log in
before you can comment on or make changes to this bug.
Description
•