981345 - When viewing mp4 file in Firefox Nightly on Android, the "external app" button in URL bar triggers "Unable to play video" in external Video Player

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Visit http://techslides.com/demos/sample-videos/small.mp4 in Firefox Nightly for Android. (or maybe (?) any mp4 file)

 2. Tap the little "android" (external app) icon at the right edge of the URL bar

 3. If you're prompted to pick an app, choose "Video player"

EXPECTED RESULTS: Video plays in Android video player app.

ACTUAL RESULTS: Video player app pops up a dialog saying:
   "Can't play this video [OK]"


Firefox Nightly gives the broken ACTUAL RESULTS. Version 30.0a1 2014-03-08

Firefox release & beta give EXPECTED RESULTS. Versions 27.0, 28.0

So, regression.

Comment 1

[Daniel Holbert [:dholbert]]

This might be a recent regression. At least, I can't reproduce this in a slightly-old local build (from 2/27), but I can reproduce this in a local build I generated today.

The working build from 2/27 is from: https://hg.mozilla.org/mozilla-central/rev/4cfb6c61b137
Broken build from today is from: http://hg.mozilla.org/mozilla-central/rev/21f293fc8d34

(Wide) regression range, based on that:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=4cfb6c61b137&tochange=21f293fc8d34

Comment 2

[Aaron Train [:aaronmt]]

I suspect bug 959108 maybe?

e3ce8fb65c5f	Eugen Sawin — Bug 959108 - Update helper apps page actions URL on location change. r=wesj

Comment 3

[Eugen Sawin [:esawin]]

Attachment: Fix HelperApp callback context

Fixes missing callback context from bug 959108.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/086c209d637f

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/086c209d637f