981430 - Convert WinUtils consumer of imgIContainer::GetFrame to act on a Moz2D SourceSurface

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

We should convert the WinUtils consumer of imgIContainer::GetFrame to act on a Moz2D SourceSurface.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8388233 [details] [diff] [review]
patch

Review of attachment 8388233 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/windows/WinUtils.cpp
@@ +763,5 @@
> +                 ColorPattern(Color(1.0f, 1.0f, 1.0f, 1.0f)));
> +    dt->DrawSurface(surface,
> +                    Rect(16, 16, 16, 16),
> +                    Rect(Point(0, 0),
> +                         Size(surface->GetSize().width, surface->GetSize().height)));

This will scale the input surface to 16x16, the old code just drew 16x16 pixels from the top left of it.

See http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxContext.cpp#595

@@ +778,5 @@
>    }
>  
> +  // Allocate a new buffer that we own and can use out of line in
> +  // another thread.
> +  uint8_t *data = SurfaceToPackedBGRA(dataSurface);

Still an unnecessary copy here in the mURLShortcut case, but not a regression so I guess nobody cares too much.

Comment 3

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c25dfac7ab7b

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c25dfac7ab7b