981458 - [Sora][PTS][HFP] TC_AG_PSI_BV_03_I some cases failed.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Bluetooth, defect, P1)

Description

[sync-1]

FFOS1.3 Mozilla build ID: 20140208004002
 
 
 For case TC_AG_PSI_BV_03_I, fail log as:
 
 Test case : TC_AG_PSI_BV_03_I started
         - SDP Service record for PTS: 'Handsfree HF' successfully registered
         - The IUT claims support for the following eSCO LMP packet types: EV3,
 2-EV3, 
         - The IUT claims support for the following eSCO LMP packet types: EV3,
 2-EV3, 
         - AT: SPP connect succeeded
         - AT: WARNING: IUT does not report support for AT+CHLD=3 in its +CHLD
 response, but TSPC_HFP_2_12c is set to TRUE
         - AT: Service Level Connection established
         - AT: post SLC command sequence complete
         - MTC: SIGNAL indication recieved: 4
         - MTC: SIGNAL indication recieved: 5
         - MTC: SIGNAL indication recieved: 4
         - MTC: SIGNAL indication recieved: 5
         - FATAL ERROR (AT): Invalid +CIEV received
         - MTC received unexpected EXIT message from AT component
         - AT: Service Level Connection disabled
         - MTC: Test case ended
 Final Verdict : Inconclusive

Comment 1

[Ben Tian (inactive)]

1.3 doesn't support AT+CHLD=3 (conference call). You should uncheck TSPC_HFP_2_12c in PICS.

Comment 2

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Hi Ben -

Not sure if you know this, but is the TSPC_HFP_2_12c a mandatory test case for HFP?

Thanks

Vance

Comment 3

[Ben Tian (inactive)]

(In reply to Vance Chen [:vchen][[e-mail]] from comment #2)
> Hi Ben -
> 
> Not sure if you know this, but is the TSPC_HFP_2_12c a mandatory test case
> for HFP?
No, it's optional.

Comment 4

[Kunny Liu]

OK, please close this Bug. Thanks!

Comment 5

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Hi Ben -

After some discussions with our partners, we find that the reason Sora fail this test case is not because the wrong PICS of TSPC_HFP_2_12c, but because it cannot pass the following test case:

5.4.3.3 TP/PSI/BV-03-I [Transfer Battery Level Indication]

You can find the the detail in the attached spec.

So my question is, does this test case mandatory? because according to TCL, it is...

Comment 6

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I think the problem is related to - FATAL ERROR (AT): Invalid +CIEV received. Not warning message in PTS log.

Comment 7

[Ben Tian (inactive)]

Kunny,

The test case verifies whether DuT sends notification to BT headset when battery level changes. Some info we need:
1) Please provide .cfa file for investigation.
2) How do you simulate battery level change on DuT?

Comment 8

[Kunny Liu]

Attachment: PSI ISSUE.cfa

We have two ways to change battery level:
1.Into adb shell and use command : "echo $(number within 100) > sys/class/power_supply/battery/capacity"
2.Use the charger to fully charge battery.

Comment 9

[Ben Tian (inactive)]

Attachment: Patch 1 (v1): Revise +CIEV string for battery charge indicator

The bug results from incorrect +CIEV string for battery charge indicator.

Comment 10

[Gina Yeh [:gyeh] [:ginayeh]]

Comment on attachment 8389708 [details] [diff] [review]
Patch 1 (v1): Revise +CIEV string for battery charge indicator

Review of attachment 8389708 [details] [diff] [review]:
-----------------------------------------------------------------

Seems like function SendCommand() could be polished and stop someone making the same mistake again. Let's ship the patch first and please file a follow-up then. :)

Comment 11

[Ben Tian (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/db7b1775f460

Comment 12

[Ben Tian (inactive)]

Request 1.3? as it fails bluetooth certification.

Comment 13

[Joe Cheng [:jcheng] (please needinfo)]

ni? Fabrice for approval 
BT cert blocker should be 1.3+

Comment 14

[Ben Tian (inactive)]

Comment on attachment 8389708 [details] [diff] [review]
Patch 1 (v1): Revise +CIEV string for battery charge indicator

NOTE: This flag is now for security issues only. Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
  882551
User impact if declined:
  Bluetooth certification test case TC_AG_PSI_BV_03_I fails.
Testing completed:
  Passed bluetooth certification test case TC_AG_PSI_BV_03_I.
Risk to taking this patch (and alternatives if risky): 
  None.
String or UUID changes made by this patch:
  None.

Comment 15

[Kunny Liu]

Attachment: PSI.cfa

Hi all:
After merge the patch from comment 14, this case still failed. Please check:
Test case : TC_AG_PSI_BV_03_I started
	- Verifying dongle settings, disabling eSCO
	- Dongle verification complete
	- SDP Service record for PTS: 'Handsfree HF' successfully registered
	- The IUT claims support for the following eSCO LMP packet types: EV3, 2-EV3, 
	- The IUT claims support for the following eSCO LMP packet types: EV3, 2-EV3, 
	- The IUT claims support for the following eSCO LMP packet types: EV3, 2-EV3, 
	- The IUT claims support for the following eSCO LMP packet types: EV3, 2-EV3, 
	- AT: SPP connect succeeded
	- AT: Service Level Connection established
	- AT: post SLC command sequence complete
	- Guard timer timed out
	- AT: Service Level Connection disabled
	- MTC: Test case ended
Final Verdict : Inconclusive

Comment 16

[Ben Tian (inactive)]

Kunny,

Did you follow the test instruction to change battery level? The .cfa shows there were no action for 2:47 after HFP is connected, and PTS shows time out.
  - Guard timer timed out

Also did you recently change battery level notification in driver? I've verified the patch on my Sora yesterday and it passed. I wonder whether there are some change in battery driver and bluetooth doesn't get notification at all.

Comment 17

[Kunny Liu]

(In reply to Ben Tian [:btian] from comment #16)
> Kunny,
> 
> Did you follow the test instruction to change battery level? The .cfa shows
> there were no action for 2:47 after HFP is connected, and PTS shows time out.
>   - Guard timer timed out
> 
> Also did you recently change battery level notification in driver? I've
> verified the patch on my Sora yesterday and it passed. I wonder whether
> there are some change in battery driver and bluetooth doesn't get
> notification at all.

I'll check again by battery charger.
BTW,how do you change battery level ?

Comment 18

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/db7b1775f460

Comment 19

[Ben Tian (inactive)]

(In reply to Kunny Liu from comment #17)
> (In reply to Ben Tian [:btian] from comment #16)
> > Kunny,
> > 
> > Did you follow the test instruction to change battery level? The .cfa shows
> > there were no action for 2:47 after HFP is connected, and PTS shows time out.
> >   - Guard timer timed out
> > 
> > Also did you recently change battery level notification in driver? I've
> > verified the patch on my Sora yesterday and it passed. I wonder whether
> > there are some change in battery driver and bluetooth doesn't get
> > notification at all.
> 
> I'll check again by battery charger.
> BTW,how do you change battery level ?

As you suggested in comment 8:
> 1.Into adb shell and use command : "echo $(number within 100) >
> sys/class/power_supply/battery/capacity"

Comment 20

[Kunny Liu]

Hi all:
we have passed this case. Thanks！

Comment 21

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

(In reply to Kunny Liu from comment #20)
> Hi all:
> we have passed this case. Thanks！

Great! Kunny thanks for your help to double verify our patch in your Lab!!

Vance

Comment 22

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g28_v1_3/rev/b021cf83cb5d

Comment 23

[Jason Smith [:jsmith]]

Alison - Can you look into adding test coverage this?

Comment 24

[Alison Shiue]

(In reply to Jason Smith [:jsmith] from comment #23)
> Alison - Can you look into adding test coverage this?

Hi Jason,

I am not sure what kind of cases you want to add to moztrap. 

PTS(Profile Tuning Suite) is a testing tool that automates protocol and profile interoperability testing.
https://www.bluetooth.org/en-us/test-qualification/test-tools-overview/profile-tuning-suite/pts-in-depth

Here is the page to illustrate how to prepare PTS testing environment:
https://wiki.mozilla.org/B2G/QA/Bluetooth_PTS

Because these PTS test cases are to make sure our BT module is followed BT certification, all cases are defined by BT.
Thus, if you really want add them to moztrap, we suggest just add one case. 
This case would look like:
[Prerequisite] Prepare PTS test environment
[Steps] 1. Run all PTS test cases
[Expect result] All pass

Comment 25

[Jason Smith [:jsmith]]

Ah didn't know that. Given that this is automated, we don't need to add moztrap test cases for this.