981468 - [Sora][Call] [MPTY] Can't hide keypad during a multiparty call.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[sync-1]

Firefox OS v1.3
 Mozilla build ID: 20140226004002
 
 Created an attachment (id=659959)
 Logcat for this PR
 
 DEFECT DESCRIPTION:
  User can't hide keypad during a multiparty call.
 
  REPRODUCING PROCEDURES:
  1. Idle -> Enter " Phone " App -> Establish a Call(10010) -> Tap "Add call" icon -> Establish the second call(10086) -> Merge the two calls -> Open the keypad during the multiparty call -> Hide the keypad -> Can't hide the keypad(K.O)
 
 
  EXPECTED BEHAVIOUR:
  User can hide keypad during a multiparty call.
 
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
 
  REPRODUCING RATE:
  100%
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Attachment: Logcat for this PR

Comment 2

[sync-1]

Attachment: Sorry,update the logcat

Comment 3

[Vance Chen [:vchen][skype:vance.lucida][[e-mail]]]

Confirmed can still reproduce this issue on Moz build 20140305040055.

Thanks

Vance

Comment 4

[Mingming ZHAO]

Hi Vance,

During multiparty call, display the keypad, input some numbers, the numbers can not be displayed. Please check also. Thanks! :)

Comment 5

[Jason Smith [:jsmith]]

(In reply to Mingming ZHAO from comment #4)
> Hi Vance,
> 
> During multiparty call, display the keypad, input some numbers, the numbers
> can not be displayed. Please check also. Thanks! :)

That sounds like a different bug - can you open a new bug for that?

This is basic bustage, so I'm nominating this.

Comment 6

[Maria Angeles Oteo (:oteo)]

Just adding that once we open the keypad during the multiparty call, not only we can not hide it, besides we can not enter in the Group detail so we can not hang up to a unique participant and continue the conversation with the rest, we need to hang up all of them at the same time what it's even worse.

Comment 7

[Preeti Raghunath(:Preeti)]

David,

Please help review and reassign.

Comment 8

[David Scravaglieri [:scravag]]

Etienne, could you reproduce this bug ?

Comment 9

[Etienne Segonzac (:etienne)]

(In reply to David Scravaglieri [:scravag] from comment #8)
> Etienne, could you reproduce this bug ?

Yes, taking.

Comment 10

[Etienne Segonzac (:etienne)]

Attachment: Gaia PR

We had JS errors occurring in this case. This patch fixes them and lets you hide the keyboard properly.

Also when the keypad is active the rest of the screen isn't actionable (by design), so hiding the conference group disclosure button when the keypad is displayed since it's not actionable.

Comment 12

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8389790 [details] [review]
Gaia PR

Sorry for the late review, Etienne.

LGTM. r=me

Comment 13

[Etienne Segonzac (:etienne)]

https://github.com/mozilla-b2g/gaia/commit/36b470c47daed3c763f6e263e4b3f57be1828fae

Comment 14

[Etienne Segonzac (:etienne)]

Comment on attachment 8389790 [details] [review]
Gaia PR

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): conference call support
[User impact] if declined: see Description
[Testing completed]: manually tested with 1 call, 2 calls and 1 conference call + unit tested
[Risk to taking this patch] (and alternatives if risky): pretty low
[String changes made]: none

Comment 15

[Ryan VanderMeulen [:RyanVM]]

v1.3: 2ea2aab306bd1c941719160cdcb49ee9d755dc17

Comment 16

[Loli (:lolimartinezcr)]

Tested and working
1.3
Platform version: 28.0
Build ID: 20140319100231
Git commit: f2f2be55

1.4
Platform version: 30.0a2
Build ID: 20140319105930
Git commit: c036afe