98147 - The 'ViewAll attachments' link should be greyed out if there are none

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, defect, P3)

Description

[GavinS]

The 'ViewAll' link in the new attachments table should be unavailable if there
are no links.

And/Or if you click on it, and there are no attachments, then the

http://bugzilla.mozilla.org/attachment.cgi?bugid=98074&action=viewall

page should say 'there are no attachments to view', otherwise, you get a page
that is potentially confusing, which says it is 'Viewing All Attachments', but
there aren't actually any there.

Comment 1

[Vlad Dascalu]

Attachment: Makes the "View All" link gray and not-clickable if there aren't any attachments to be displayed.

Tested on my local Bugzilla installation and it works like expected.

Comment 2

[Vlad Dascalu]

Attachment: Removes the link "View All" if they're nothing to be seen.

Comment 3

[Vlad Dascalu]

Attachment: Removed != 0 condition compared to previous versions.

Comment 4

[Christian Reis]

Comment on attachment 127924 [details] [diff] [review]
Removed != 0 condition compared to previous versions.

r=kiko, nice work

Comment 5

[Vlad Dascalu]

<-- me

Comment 6

[Dave Miller [:justdave]]

I'm going to let Myk make the approval call on this one since it's a UI issue

Comment 7

[Myk Melez [:myk] [@mykmelez]]

Thanks for the patch.  The coloring should be done with CSS rather than the font
tag, but that's not a tragedy.  The idea itself is a good one.  a=myk

Comment 8

[Myk Melez [:myk] [@mykmelez]]

Err, sorry, I was looking at an earlier patch.  Actually, I like the greying
effect; it's standard for indicating that UI controls are disabled, so a patch
that did that (via CSS) would be ideal if you have time for it (otherwise check
this one in; I maintain my a=myk).

Comment 9

[Vlad Dascalu]

Attachment: New version per myk's suggestions.

This should be ready for checkin then.

Comment 10

[Vlad Dascalu]

Comment on attachment 128012 [details] [diff] [review]
New version per myk's suggestions.

Setting kiko's r+ from the previous one.

Comment 11

[Myk Melez [:myk] [@mykmelez]]

Kiko needs to explicitly say that his r= can be migrated to the newer
attachment, but I've reviewed it, and it looks good, so the r= can stand, as
does my a=.  Go ahead and check it in if you have access, or I'll check it in if
you don't.

Comment 12

[Vlad Dascalu]

I don't have access, so a checkin on this would be appreciated.

Thanks for letting me know about the r+ transition policy.

Comment 13

[Myk Melez [:myk] [@mykmelez]]

Checking in css/edit_bug.css;
/cvsroot/mozilla/webtools/bugzilla/css/edit_bug.css,v  <--  edit_bug.css
new revision: 1.3; previous revision: 1.2
done
Checking in template/en/default/attachment/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/list.html.tmpl,v
 <--  list.html.tmpl
new revision: 1.9; previous revision: 1.8
done

Comment 14

[Christian Reis]

For the record, I did say on IRC that he could carry over my r=.

Comment 15

[Vlad Dascalu]

I really don't know how that TAB got there. It's the 2nd time this is happening.

I'm used with TAB environments, but I really fail to see how I could have pushed
that key, especially after the line ended. Oh well, I'll switch completely to
vim then, since it has support for auto-expanding TABs.

Really sorry about it. :(