981471 - [MediaEncoder] Validate input image in OMXVideoEncoder::Encode()

Status: RESOLVED INVALID

(Core :: Audio/Video: Recording, defect)

Description

[John Lin [:jhlin][:jolin]]

To pass the test of :CJKu in bug 979812 attachment 8385986 [details]. I.e., return error when the input image has no actual buffer.

Comment 1

[John Lin [:jhlin][:jolin]]

Attachment: bug-981471-validate-input-image.patch

Check input images and reject invalid or unsupported ones.

Comment 2

[Benjamin Chen [:bechen]]

Comment on attachment 8388343 [details] [diff] [review]
bug-981471-validate-input-image.patch

Review of attachment 8388343 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/media/omx/OMXCodecWrapper.cpp
@@ +236,5 @@
> +{
> +  if (!aImage) {
> +    // Muted/blank/black image.
> +    return true;
> +  } else {

Looks like that you don't need the "else" scope, remove the "else" and indent them.

Comment 3

[John Lin [:jhlin][:jolin]]

In fact the invalid image will be caught by assertion at [1] so there seems no need for additional validation.

[1] http://dxr.mozilla.org/mozilla-central/source/content/media/omx/OMXCodecWrapper.cpp?from=OMXCodecWrapper.cpp#401