Open Bug 981536 Opened 10 years ago Updated 2 years ago

Enable VerifyHasDirtyRootAncestor

Categories

(Core :: Layout, enhancement)

enhancement

Tracking

()

People

(Reporter: jkitch, Unassigned)

Details

Bug 379229 introduced a check to ensure that the ancestors of frames with dirty bits set were themselves dirty.  This is helpful as there is an optimisation in nsPresShell which stops marking the frame tree dirty once an already dirty parent is discovered, which has caused some problems (eg. bug 522393).

However this check was never enabled.  Comments indicate it was blocked by bug 372769, but that was fixed a while ago.

Should this be enabled to help stop future problems?

Try run:
https://tbpl.mozilla.org/?tree=Try&rev=b334b28e9299
Enabling this results in a lot of assertions, although I have not yet investigated any common causes.
Yes, I think we should try to enable this check now.
Severity: normal → enhancement
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.