981578 - [tarako]trout FM support

Status: RESOLVED FIXED

(Core :: Hardware Abstraction Layer (HAL), defect)

Description

[James Zhang (Spreadtrum)]

Attachment: tavarua_fm_support.patch

Trout FM is differnet from beken and any other FM hardware. It must denpend on pcm audio hal interface. Please review this patch, it need merge into v1.3t.

Comment 1

[James Zhang (Spreadtrum)]

Jesse provide this patch.

Comment 2

[Steven Yang [:styang]]

Hi Michael, would you mind to take a look on this patch? thanks!

Comment 3

[James Zhang (Spreadtrum)]

Only tarako need this patch, fugu and dolphin need not this patch.
So we only need merge it into v1.3t.

Comment 4

[James Zhang (Spreadtrum)]

Need merge into v1.3t for tarako only.

Comment 5

[Michael Wu [:mwu]]

Comment on attachment 8388458 [details] [diff] [review]
tavarua_fm_support.patch

Review of attachment 8388458 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry, I don't think this patch belongs in gecko. Instead, I believe this thread should be started when AudioSystem::setDeviceConnectionState is called. When gecko wants to turn FM on, it will notify the audio system using that call, at which point an appropriate thread can be started for FM. One way to do this is to change setDeviceConnectionState inside hardware/libhardware_legacy/audio/AudioPolicyManagerBase.cpp. The only tricky thing is that the bit gecko uses to indicate the FM radio device is not the same as the ones that this platform uses. On gecko, AUDIO_DEVICE_OUT_FM = 0x80000. It looks like this code already handles FM devices, but it doesn't know about the different bit that gecko uses. Let me know if you need any help with this.

Comment 6

[Jesse]

If I put the code in 'AudioPolicyManagerBase.cpp', The libhardware_legacy library will depend on gecko library due to gecko AudioStream references, otherwise gecko AudioChannelManager can't manager the fm audio stream.

Comment 7

[James Zhang (Spreadtrum)]

Hi Michael,

   Can you give some libhardware_legacy patch for tarako?

   We need your help.

Comment 8

[Michael Wu [:mwu]]

I'll take this.

Comment 10

[Michael Wu [:mwu]]

Attachment: tarako-fm-radio-player

Comment 11

[Michael Wu [:mwu]]

James, let me know if this patch works for you.

Comment 12

[Jesse]

looks good to me , have not tested it. The only defect may be that the code does not delete FMRadioPlayer object when fm stopped.

Comment 13

[James Zhang (Spreadtrum)]

Jess will commit this patch on my side.

Comment 14

[Joe Cheng [:jcheng] (please needinfo)]

do we need this patch on the 1.3T branch? Thanks if so, can you commit to 1.3T? and fixed on  status-b2g-v1.3T? Thanks

Comment 15

[Jason Smith [:jsmith]]

(In reply to Joe Cheng [:jcheng] from comment #14)
> do we need this patch on the 1.3T branch? Thanks if so, can you commit to
> 1.3T? and fixed on  status-b2g-v1.3T? Thanks

Joe - the patch needs to be a r+ before we land it.

Comment 16

[Michael Wu [:mwu]]

(In reply to Joe Cheng [:jcheng] from comment #14)
> do we need this patch on the 1.3T branch? Thanks if so, can you commit to
> 1.3T? and fixed on  status-b2g-v1.3T? Thanks

This patch applies to a spreadtrum side repo.

Comment 17

[Michael Wu [:mwu]]

(In reply to Jesse from comment #12)
> looks good to me , have not tested it. The only defect may be that the code
> does not delete FMRadioPlayer object when fm stopped.

We actually don't need to dynamically allocate the FMRadioPlayer object at all. It only has three fields, so it might as well be statically allocated.

Comment 18

[James Zhang (Spreadtrum)]

Fixed on my side.

Michael, thank you very much for your kindly help.


commit 2222043791e7616bb09eb1c572f99981b9de195f
Author: jesse.ji <[e-mail]>
Date:   Fri Mar 21 11:01:17 2014 +0800

    Bug #285579  Move trout FM support in hardware repo, not in gecko.
    
    [bug number  ] 285579
    [root cause  ]
    [changes     ]
    [side effects]
    [reviewers   ]
    [self test   ] self test
    
    Change-Id: I38bb01aa8fa6d9c0ca6ba83b82cc5321c5113f4c