981592 - Double click folder in right side pane does not work

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Alice0775 White]

Build Identifier:
https://hg.mozilla.org/mozilla-central/rev/21f293fc8d34
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140309030204

Steps To Reproduce:
1. Open Library Ctrl+Shift+B
2. Double click folder in right side pane

Actual Results:
Nothing happens

Comment 1

[Alice0775 White]

Regression(m-i)
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/78fa90a29c43
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140304114257
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/722fd1b0e050
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 ID:20140304124457
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=78fa90a29c43&tochange=722fd1b0e050
Regressed by:
722fd1b0e050	Marco Bonardo — Bug 435851 - dragging a folder shortcut drags the concrete folder instead. r=mano

Comment 2

[Alice0775 White]

This problem happens with the following condition:
1. Selected parent folder in left side pane is collapsed.
2. Then, Child folder listed in right side pane cannot expand.

In other words,　If parent folder in left side pane is expanded , child folder listed in right side pane can expand by double click.

Comment 3

[Marco Bonardo [:mak]]

it's due to changed behavior of selectItems (that is actually intended as a perf improvement).
The openFlatContainer method should first ensure to open the currently left pane selected container. I should also add a test for this.

Comment 4

[Marco Bonardo [:mak]]

Attachment: patch v1

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/fx-team/rev/56ac183ad1e2

At this point doesn't make sense to spend triage time on this

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/56ac183ad1e2