981593 - Autophone - Incorrect measurement of throbberstart

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect)

Description

[Bob Clary [:bc] (inactive)]

Attachment: badstarttime.txt

There are several cases where starttime > throbberstop. This is a regression from bug 964645.

select * from rawfennecstart where runstamp > '2014-03-01' and (starttime > throbberstart or starttime > throbberstop);

Comment 1

[Bob Clary [:bc] (inactive)]

Attachment: bug-981593-throbberstart.patch

I haven't been able to see this bug in action partially due to the fact I've turned off debugging in production. This should guard / report about bogus measurements and may help, but I am not absolutely certain.

This mostly occurs for my nexus 7 2013 devices:

mysql> select count(*), phoneid from rawfennecstart where runstamp > '2014-01-01' and (starttime > throbberstart or starttime > throbberstop) group by phoneid;
+----------+----------------------------------+
| count(*) | phoneid                          |
+----------+----------------------------------+
|        1 | 98_0c_82_33_ec_8d_samsung-gs2    |
|        6 | 98_d6_f7_69_34_aa_nexus-4-jdq39  |
|        1 | 98_d6_f7_69_37_05_nexus-4-jdq39  |
|        1 | c8_aa_21_ac_0c_b5_droid-pro      |
|       52 | d8_50_e6_7a_7b_de_nexus-7-jss15q |
|       58 | d8_50_e6_7a_86_a2_nexus-7-jss15q |
+----------+----------------------------------+

Comment 2

[Mark Côté [:mcote]]

Comment on attachment 8389225 [details] [diff] [review]
bug-981593-throbberstart.patch

Review of attachment 8389225 [details] [diff] [review]:
-----------------------------------------------------------------

Hm yeah that's weird.  Your changes look fine; hopefully they help you track down the problem.

Comment 3

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/32ddd4f3cca5919ac4554b7785fc2e5b3b02bd5f