981636 - Double tap to zoom in does not work on tablets in landscape mode

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Flaviu Cos]

Environment: 
Device: Lenovo Yoga Tab 10 (Android 4.2.2);
Build: Nightly 30.0a1 (2014-03-04);

Steps to reproduce:
1. Go to planet.mozilla.org;
2. Change the orientation to landscape;
3. Double tap to zoom in.

Expected result:
The page is successfully zoomed in.

Actual result:
Double tap does not work in landscape.

Notes:
Also reproducible on Asus Transformer Tab (Android 4.0.3);
The bug might be tablet specific since is not reproducible on Google Nexus 5 (Android 4.4.2).

Comment 1

[Kartikaya Gupta (email:[e-mail])]

This is almost certainly the result of bug 941995.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Actually, maybe not. If that were the case I'd expect it to fail on the N5 as well. Removing depedency for now; but if this is a regression then getting a regression-window to confirm that dependency would be a good first step.

Comment 3

[Flaviu Cos]

Last good revision: 6e3ec93efe1d (2014-02-18)
First bad revision: 8122ffa9e1aa (2014-02-19)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=6e3ec93efe1d&tochange=8122ffa9e1aa

Comment 4

[Aaron Train [:aaronmt]]

This is not reproducible on my Asus Nexus 7 (2013, Android 4.4.2), but is reproducible on my Sony Xperia Z Tablet (Android 4.3)

The above window-range does not look right in comment #3. Testing locally yields:

Last good revision: a19e4c6dc2a9
First bad revision: ff2a1d3d39f2

Pushlog:

https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=a19e4c6dc2a9&tochange=ff2a1d3d39f2

Of which has already been mentioned here.

Comment 5

[Aaron Train [:aaronmt]]

+ CC, :botond, wesj

Comment 6

[Kartikaya Gupta (email:[e-mail])]

I have a patch to fix this; will upload once Bugzilla attachments work again.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Attachment: Only disable double-tap if a viewport is specified

Comment 8

[Matt Brubeck (:mbrubeck)]

Comment on attachment 8388675 [details] [diff] [review]
Only disable double-tap if a viewport is specified

Review of attachment 8388675 [details] [diff] [review]:
-----------------------------------------------------------------

What does Chrome do in this case?

Comment 9

[Kartikaya Gupta (email:[e-mail])]

ni? AaronMT to check Chrome on a tablet. I don't have any tablets other than the Tab running Honeycomb and it can't run Chrome.

Comment 10

[Aaron Train [:aaronmt]]

In Chrome, when I double-tap the page zooms out, when I double-tap again the page restores to how it loaded:

Before: http://people.mozilla.org/~atrain/mobile/tests/981636-chrome-before.png
After: http://people.mozilla.org/~atrain/mobile/tests/981636-chrome-after.png

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/6cecd6870c69

Comment 12

[Brad Lassey [:blassey] (use needinfo?)]

Kats, should we just back out bug 941995? What effective change does the combo of this and bug 941995 make?

Comment 13

[Kartikaya Gupta (email:[e-mail])]

Why 29+? It only affects 30, because that's where bug 941995 landed.

And no I think the patch in this bug fixes an obvious error in my previous patch; we can just let them ride the trains together - no need to back anything out.

Comment 14

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #13)
> Why 29+? It only affects 30, because that's where bug 941995 landed.
bug 941995 is tracking 29. If there is no intent to uplift, let's bump them both down.

Comment 15

[Kartikaya Gupta (email:[e-mail])]

Yeah I'd rather not uplift either.

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6cecd6870c69

Comment 17

[Cristina Madaras, QA [:CristinaM]]

Verified as fixed in builds:
- 30.0a2 (2014-03-31);
- 31.0a1 (2014-03-31);
Device: Asus Transformer (Android 4.2.1) and Acer Iconia (Android 3.2.1)