981676 - ANR: Progress bar bulb causes frequent hang in android.view.GLES20Canvas.nFinish on Android 4.3

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

This new hang appeared starting with the 2014-03-01 nightly and seems to be specific to Android 4.3 Jelly Bean (API level 18). It seems to get a lot worse with the Xposed framework installed.

Without the Xposed framework, it was the #6 ANR for the past week. The corresponding stack is,

> android.view.GLES20Canvas.nFinish
> android.view.GLES20Canvas.onPostDraw (line 257)
> android.view.HardwareRenderer$Gl20Renderer.onPostDraw (line 1806)
> android.view.HardwareRenderer$GlRenderer.draw (line 1389)
> android.view.ViewRootImpl.draw (line 2672)
> android.view.ViewRootImpl.performDraw (line 2538)
> android.view.ViewRootImpl.performTraversals (line 2154)
> android.view.ViewRootImpl.doTraversal (line 1249)
> android.view.ViewRootImpl$TraversalRunnable.run (line 6364)
> android.view.Choreographer$CallbackRecord.run (line 791)
> android.view.Choreographer.doCallbacks (line 591)
> android.view.Choreographer.doFrame (line 561)
> android.view.Choreographer$FrameDisplayEventReceiver.run (line 777)
> android.os.Handler.handleCallback (line 730)
> android.os.Handler.dispatchMessage (line 92)
> android.os.Looper.loop (line 137)
> android.app.ActivityThread.main (line 5455)
> java.lang.reflect.Method.invokeNative
> java.lang.reflect.Method.invoke (line 525)
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (line 1187)
> com.android.internal.os.ZygoteInit.main (line 1003)
> dalvik.system.NativeStart.main

With Xposed installed, it was the #1 ANR for the past week. The corresponding stack is (note the "de.robv.android.xposed.XposedBridge.main" frame),

> android.view.GLES20Canvas.nFinish
> android.view.GLES20Canvas.onPostDraw (line 257)
> android.view.HardwareRenderer$Gl20Renderer.onPostDraw (line 1806)
> android.view.HardwareRenderer$GlRenderer.draw (line 1389)
> android.view.ViewRootImpl.draw (line 2670)
> android.view.ViewRootImpl.performDraw (line 2536)
> android.view.ViewRootImpl.performTraversals (line 2152)
> android.view.ViewRootImpl.doTraversal (line 1247)
> android.view.ViewRootImpl$TraversalRunnable.run (line 6355)
> android.view.Choreographer$CallbackRecord.run (line 791)
> android.view.Choreographer.doCallbacks (line 591)
> android.view.Choreographer.doFrame (line 561)
> android.view.Choreographer$FrameDisplayEventReceiver.run (line 777)
> android.os.Handler.handleCallback (line 730)
> android.os.Handler.dispatchMessage (line 92)
> android.os.Looper.loop (line 137)
> android.app.ActivityThread.main (line 5419)
> java.lang.reflect.Method.invokeNative
> java.lang.reflect.Method.invoke (line 525)
> com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (line 1187)
> com.android.internal.os.ZygoteInit.main (line 1003)
> de.robv.android.xposed.XposedBridge.main (line 126)
> dalvik.system.NativeStart.main

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

This is Android's GL stack for drawing the UI Views, so not sure there is much we'll be able to do here.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Actually, looks like it's caused by bug 962103. The hang appeared in the 2014-03-01 nightly, which is when that bug first landed. Then that bug was backed out for the 2014-03-04 nightly and relanded in the 2014-03-05 nightly. Looking at the hang reports, there are no hangs from 3/4 but several hangs from 3/3 and 3/5, making it likely that bug 962103 caused the regression.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

I found this is caused by Android bug 10347089, which was fixed by the following two commits in Android 4.3.1 and 4.4. Unfortunately many devices are stuck at 4.3 (e.g. Galaxy Nexus), so this is still a problem.

https://android.googlesource.com/platform/frameworks/base/+/a2a70e9%5E%5E!/
https://android.googlesource.com/platform/frameworks/base/+/5d92320%5E!/

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: backout_bulb.patch

Comment 5

[Lucas Rocha (:lucasr)]

Attachment: Backout progress bar refinements from bugs 980438/962103 (r=mfinkle)

Comment 6

[Lucas Rocha (:lucasr)]

Comment on attachment 8390560 [details] [diff] [review]
Backout progress bar refinements from bugs 980438/962103 (r=mfinkle)

This patch reverts all the progress bar refinements.

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

pushed backout:
https://hg.mozilla.org/integration/fx-team/rev/549baf11d2c0

Comment 8

[Brian Nicholson (:bnicholson)]

Attachment: Fix backout of bugs 980438/962103

Something broke with the landed backout as it still has the wrong image resources.

Comment 9

[Brian Nicholson (:bnicholson)]

https://hg.mozilla.org/integration/fx-team/rev/eaabf46d60ad

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/549baf11d2c0
https://hg.mozilla.org/mozilla-central/rev/eaabf46d60ad