981715 - Refactor sync identity and service modules

Status: RESOLVED DUPLICATE of bug 1296767

(Firefox :: Sync, defect)

Description

[Chris Karlof [:ckarlof]]

browserid_identity.js has a number of hacks because of assumptions made by service.js about how it interacts with identity objects.

Comment 1

[Chris Karlof [:ckarlof]]

E.g., the sync key getter: 

  /**
   * Obtain the Sync Key.
   *
   * This returns a 26 character "friendly" Base32 encoded string on success or
   * null if no Sync Key could be found.
   *
   * If the Sync Key hasn't been set in this session, this will look in the
   * password manager for the sync key.
   */
  get syncKey() {
    if (this.syncKeyBundle) {
      // TODO: This is probably fine because the code shouldn't be
      // using the sync key directly (it should use the sync key
      // bundle), but I don't like it. We should probably refactor
      // code that is inspecting this to not do validation on this
      // field directly and instead call a isSyncKeyValid() function
      // that we can override.
      return "99999999999999999999999999";
    }
    else {
      return null;
    }
  },