981728 - Spidermonkey reports a syntax error in browser.js

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

I have a thing in my local build scripts that checks for JS syntax errors. And it found one!

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: 1-doubletap-dc9d7be

Comment 2

[Wesley Johnston (:wesj)]

Comment on attachment 8388681 [details] [diff] [review]
1-doubletap-dc9d7be

Review of attachment 8388681 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm.. Its weird that we're not seeing this in our local consoles...

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Yeah, it is. For the record, the way I'm checking is using a locally-built standalone spidermonkey binary (instructions at [1]; I tested with the latest m-c code) and the script at https://github.com/staktrace/moz-scripts/blob/master/jscheck where "js.$(uname)" points to the spidermonkey binary. The first line of the jscheck script deals with preprocessor goop, and AFAICT doesn't interfere with this particular bug.

[1] https://developer.mozilla.org/en-US/docs/SpiderMonkey/Build_Documentation

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/e6b3d4a09ea6

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e6b3d4a09ea6