981872 - Replace use of MessageDigest with NativeCrypto where applicable

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Crypto, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

via bug 959652 comment 21:

> Additionally, I noticed we use MessageDigest in other places in the sync
> code that will require the same initialization (just not at startup),
> including sha1 routines

We should replace these with NativeCrypto to avoid initializing the crypto providers on Android 4.3 and greater (in addition to the hashing performance gains).

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Patch (github)

Comment 2

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8402941 [details] [review]
Patch (github)

Comment on github PR, but r+ after streamlining.

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Replace sha-1 MessageDigest with NativeCrypto.

via github.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/12e30a3a76b1

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/12e30a3a76b1