981920 - ASAN builds should use -fno-omit-frame-pointer by default

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Andrew McCreight [:mccr8]]

ASAN uses a fast stack unwinder that relies on frame pointers.  ASAN builds on TBPL are optimized, and at least based on the try pushed I've done, do not seem to have -fno-omit-frame-pointer, resulting in some useless stacks in LSAN reports I've been investigating.  Locally, adding "ac_add_options --enable-profiling" to my mozconfig fixed the problem with the stacks.  Maybe tying this to "ac_add_options --enable-address-sanitizer" is the way to go?

I'm not entirely sure what is required for this, but it seems like it would require modifying /build/autoconf/frameptr.m4 .

Decoder, is there anything you do in your ASAN runs to deal with this?

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: ASAN builds should use -fno-omit-frame-pointer by default.

Comment 2

[Andrew McCreight [:mccr8]]

In IRC, decoder said he thought we already had profiling enabled for ASAN builds, so he'd be okay with something like this.

Comment 3

[Andrew McCreight [:mccr8]]

Thanks for the review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/a0ee12861380

Comment 4

[Andrew McCreight [:mccr8]]

try run: https://tbpl.mozilla.org/?tree=Try&rev=659d8f58b430

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a0ee12861380