Closed Bug 981920 Opened 8 years ago Closed 8 years ago

ASAN builds should use -fno-omit-frame-pointer by default

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla31

People

(Reporter: mccr8, Assigned: mccr8)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

ASAN uses a fast stack unwinder that relies on frame pointers.  ASAN builds on TBPL are optimized, and at least based on the try pushed I've done, do not seem to have -fno-omit-frame-pointer, resulting in some useless stacks in LSAN reports I've been investigating.  Locally, adding "ac_add_options --enable-profiling" to my mozconfig fixed the problem with the stacks.  Maybe tying this to "ac_add_options --enable-address-sanitizer" is the way to go?

I'm not entirely sure what is required for this, but it seems like it would require modifying /build/autoconf/frameptr.m4 .

Decoder, is there anything you do in your ASAN runs to deal with this?
Assignee: nobody → continuation
In IRC, decoder said he thought we already had profiling enabled for ASAN builds, so he'd be okay with something like this.
Attachment #8389344 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/a0ee12861380
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.