981936 - Split content/canvas/test/webgl into webgl-mochi and webgl-conformance

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Currently, we have a content/canvas/test/webgl/non-conf-tests folder. This is weird, so we should do the right thing.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: patch 1: Move All The Things

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: patch 2: Repair hardcoded paths

Fix the hardcoded paths and make them easier to fix.

Comment 3

[u480271]

Comment on attachment 8388904 [details] [diff] [review]
patch 1: Move All The Things

Review of attachment 8388904 [details] [diff] [review]:
-----------------------------------------------------------------

Does webgl-mochi need a 00_test_list.txt file?

Comment 4

[u480271]

Comment on attachment 8388906 [details] [diff] [review]
patch 2: Repair hardcoded paths

Review of attachment 8388906 [details] [diff] [review]:
-----------------------------------------------------------------

To the best of my ability, I think these changes are valid, I would like feedback from bjacob (who's on PTO :-( )

Comment 5

[Kelsey Gilbert [:jgilbert]]

(In reply to Dan Glastonbury :djg :kamidphish from comment #3)
> Comment on attachment 8388904 [details] [diff] [review]
> patch 1: Move All The Things
> 
> Review of attachment 8388904 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Does webgl-mochi need a 00_test_list.txt file?

No, those are used by the conformance suite only.

Comment 6

[u480271]

Comment on attachment 8388904 [details] [diff] [review]
patch 1: Move All The Things

Review of attachment 8388904 [details] [diff] [review]:
-----------------------------------------------------------------

r+ conditional on answering: Does webgl-mochi need a 00_test_list.txt file?

Comment 7

[Kelsey Gilbert [:jgilbert]]

(In reply to Dan Glastonbury :djg :kamidphish from comment #6)
> Comment on attachment 8388904 [details] [diff] [review]
> patch 1: Move All The Things
> 
> Review of attachment 8388904 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> r+ conditional on answering: Does webgl-mochi need a 00_test_list.txt file?

Nope. Those are files internal to the test population code in the conformance suite.

Comment 8

[Kelsey Gilbert [:jgilbert]]

Clean Try run:
https://tbpl.mozilla.org/?tree=Try&rev=6d7cd88767a4

Comment 9

[Kelsey Gilbert [:jgilbert]]

I'll post the 2nd patch which fixes some hardcoded paths tomorrow, when bugzilla's not so spacey.

Comment 10

[Kelsey Gilbert [:jgilbert]]

Attachment: patch 2: Repair hardcoded paths

Comment 11

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 8388904 [details] [diff] [review]
patch 1: Move All The Things

Review of attachment 8388904 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/canvas/test/moz.build
@@ +5,5 @@
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +DIRS += [
> +    'webgl-conformance',
> +    'webgl-mochi',

Call it 'webgl-mochitest', don't abbreviate it, for consistency and e.g. easier grepping.

Comment 12

[Kelsey Gilbert [:jgilbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ffe8bcfac12e
https://hg.mozilla.org/integration/mozilla-inbound/rev/14f78cd007ac

Fixed with bjacob's nit.

Comment 13

[Kelsey Gilbert [:jgilbert]]

Aand bustage fix from some of the nits:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d6987eee490

Comment 14

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/ffe8bcfac12e
https://hg.mozilla.org/mozilla-central/rev/14f78cd007ac
https://hg.mozilla.org/mozilla-central/rev/0d6987eee490