981937 - Bugzilla reports "-1" notifications

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Pomax]

Attachment: http://i.imgur.com/Ojd4txr.png

Bugzilla, for a while now, is reporting -1 notifcations for me whenever I have an empty review queue. See attached screenshot.

Comment 1

[:glob ✱]

that's odd.

what does the tooltip for that notification say?

Comment 2

[Pomax]

I shall report that value the moment my review queue is empty again (because you never wake up to no review requests...)

Comment 3

[Pomax]

the tooltip when it's showing -1 reads "Flags requested of you: review (-1)"

Comment 4

[Ali Al Dallal [:alicoding]]

Yup, happen to me too and when I have 1 review it'll show 0 in notification.

Comment 5

[Ali Al Dallal [:alicoding]]

Yup, happen to me too and when I have 1 review it'll show 0 in notification.

Comment 6

[:glob ✱]

there's been a lot of database weirdness recently, so right now i can't tell if these negative values are a result of that, or if it's a problem with the code.

i've stepped through the code and it looks sane.

i have code which recalculates the number in the badge from scratch, however it doesn't reset negative values.  i'll work on a fix for that so it also resets negative values.

Comment 7

[:glob ✱]

committed:
To ssh://[e-mail]/webtools/bmo/bugzilla.git
   bf95aa6..fa99f05  4.2 -> 4.2

Comment 8

[:glob ✱]

i've run the updated recalculation code, and currently nobody has a negative counter.
i'll leave the bug open to monitor - don't hesitate to let me know if this issue reoccurs.

Comment 9

[Pomax]

certainly fixed it for me!

Comment 10

[:glob ✱]

no news is good news; marking as fixed.